Comment 61 for bug 1307545

Revision history for this message
b3nmore (b3nmore) wrote :

I ran some tests, which I recall having caused problems in the past. With the latest patch (b529706) applied, the two main issues (unwanted suspend/blank screen) are basically resolved now for *all* test cases (except maybe f) 1/2).

There are small differences for the various configuration options, which I'll list for each test case. IMO the ideal case would be, that the 'unlock dialog appears directly'. However sometimes the user must interfere manually a second time or wait additional time [1].

1) --no-lock-on-lid
2) --lock-on-lid

Test cases directly triggered by lid close:
a) xfpm lid action: lock
   i) auto lock: never
   1) delay OR manual interference (depends on close time)
   2) unlock dialog appears directly (depends on close time)
   ii) auto lock: ss activates (after autolock kicks in)
   1) delay OR manual interference
   2) unlock dialog appears directly
   iii) auto lock: ss deactivates (after autolock kicks in)
          1) delay OR manual interference
   2) unlock dialog appears directly

b) xfpm lid action: suspend
      1) unlock dialog appears directly
      2) unlock dialog appears directly

c) xfpm lid action: hibernate
      1) manual interference required
      2) manual interference required

Test cases auto lock, lid stays open (xfpm lid action: lock):
d) auto lock: ss activates
   1) unlock dialog appears directly
   2) unlock dialog appears directly
e) auto lock: ss deactivates
   1) manual interference required
   2) manual interference required

Test cases auto lock, but lid gets closed *after* the screen was locked (xfpm lid action: lock):
f) auto lock: ss activates
   1) system suspends, manual interference required
   2) system suspends, manual interference required
g) auto lock: ss deactivates
   1) manual interference required
   2) manual interference required

[1] I would call them usability issues, because the user has to take additional action although he already requested the unlock dialog by e.g opening the lid etc. So nothing really dramatic, but the user interaction required to get to the unlock screen heavily depends on situation and isn't consistent (and maybe discussed elsewhere).