Comment 7 for bug 58553

Revision history for this message
In , Yves-Alexis Perez (corsac) wrote :

(In reply to comment #2)
> Hmm, those margins are there not because I like the extra empty space, but
> rather to prevent cut-off icons.

Yes, I wasn't implying this :)
>
> The plugin size is not currently used as the icon size (there's a bug open
> about this from Benedikt), so we need to take into account the extra space used
> by the button. As far as I know a gtk button uses at least a fixed border of 1
> plus the theme-dependend x/ythickness.
>
> If there is a plugin on your panel that is bigger than than the size you set in
> the configuration it may happen that the launcher icons are smaller than the
> available space.
>
> I just tested by just removing the fixed border and I already see cut-off
> icons, so I don't think I can commit this patch.

I see, and it was the "design issues" I feared. But in this case, shouldn't the plugin be fixed to respect the panel size? When I set a panel size I expect all plugins to respect it so I end with a panel which size *is* the size I've chosen and not the size a plugin requested. In case a plugin size and the panel size mismatchs, the launcher icon may be really tiny (because it follow the panel requested size, minus margin, while the panel at the end has the "bad" plugin size.)

Regards,