Comment 7 for bug 1323019

Revision history for this message
In , Adam Purkrt (adam-purkrt-deactivatedaccount) wrote :

(In reply to Daniel Wilkins from comment #4)
> Wow, this patch still applies? I figured it was just stuck languishing for
> forever. It'd be easy enough to swap the defaults around, I just choose to
> have the ui reflect the behavior that was actually happening rather than the
> other way around; if there's actually any interest in merging the patch I'd
> be happy to orient it whichever way the dev wants.

It might be more tricky than it seems. I applied the patch directly (to xfce4-panel-4.12.0), it works. Then I played with it, and it can be reduced to only the following single change

- gtk_widget_show (plugin->label);
+ if (plugin->show_button_title)
+ gtk_widget_show (plugin->label);

The tricky part - for me - is that in the original source, in function "applications_menu_plugin_class_init", the "show-button-title" property is set to TRUE, yet in the end it is FALSE. So the "blind assumption" that the title (label) is on by default is perhaps not so blind. The real bug seems to be in the fact that the plugin->show_button_title is not "TRUE" even if it should be.