xfce4-panel 4.11 does not honor compiz virtual horizontal size correctly

[Cédric Dufour]

Hello,

When increasing compiz virtual horizontal size, xfce4-panel (4.11; Ubuntu/Trusty) workspace swicther shows the additional "workspaces" but without increasing the swicther width accordingly; the width remains as if a single "workspace" is used, and compiz "workspaces" appear squeezed within the available width (the more so as the virtual horizontal size is increased).

Reverting to xfce4-panel 4.10 (Ubuntu/Saucy) fixes the issue.

Best,

Cédric

[Cédric Dufour (cdufour-keyword-ubuntu-086000)]

Hello,
The problem comes from:
1. the pager does not use the 'wnck_workspace_get_{width,height}' to calculate its aspect ratio
2. the pager does not recalculate its aspect ratio when Compiz workspaces/viewports settings are changed
Please consider attached patch to fix this behavior.
Once applied, pager size is correct for both Compiz and XFWM4.
Thanks and cheers,
Cédric

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "xfce4-panel.fix-pager-size-for-compiz-viewports.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. Please forward your patch to the upstream developers by filing a bug report on the Xfce bug tracker.

https://bugzilla.xfce.org/

[Djnz00 (djnz00)]

Created attachment 6076
patch

This bug is originally submitted here: https://bugs.launchpad.net/ubuntu/+source/xfce4-panel/+bug/1292820 by Cedric Dufour. Patch is also his.

1. the pager does not use the 'wnck_workspace_get_{width,height}' to calculate its aspect ratio
2. the pager does not recalculate its aspect ratio when Compiz workspaces/viewports settings are changed

Please consider attached patch to fix this behavior.
Once applied, pager size is correct for both Compiz and XFWM4.

[Djnz00 (djnz00)]

bump!

[Charles Bos (charlesbos1)]

Created attachment 6447
Panel switcher screenshot (wrong aspect ratio)

[Charles Bos (charlesbos1)]

Created attachment 6448
Panel switcher screenshot (correct aspect ratio)

[Charles Bos (charlesbos1)]

I've not got much to say other than that this affects me too - Arch Linux, Compiz 0.9.12, Xfce 4.12. To illustrate the problem, I've attached a couple of screenshots.

[Charles Bos (charlesbos1)]

Attached patch works here on Arch as well.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Theo Linkspfeifer (lastonestanding)]

Is this patch still needed?

[Michael Kogan (michael-kogan)]

The patch is not compatible with Xfce 4.14 any more, is there somebody knowledgeable enough to look into it and check if it can be modified to work with the new Xfce?

[erikjanp (ej-lfs)]

Created attachment 9004
fix pager size for compiz viewports

Here's an updated patch for xfce4-panel-4.14.
When applying, it can give some 'offset xxx lines' notices but that shouldn't be a problem.

[Michael Kogan (michael-kogan)]

Thanks, works perfectly!