Comment 3 for bug 507072

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

It seems that the same guy that provide a patch for rssi, also provide a patch for xchat at http://adipose.attenuate.org/~stephen/ircd-seven/xchat-ircd-seven-identify-msg.patch.txt
It looks a bit different to the one you're submitting: could you have a look and see what is done differently? At a first glance, the way the patch handles the command is cleaner, and less attack prone (by checking the length first, and then each character one by one, as done for other commands).

Thanks,
Fabrice