Ubuntu
x-loader package

  1. Bug #652850
  2. Comment #1

Comment 1 for bug 652850

Revision history for this message
Peter Maydell (pmaydell) wrote :

Also, we ought to put the #defines from drivers/k9f1g08r0a.c in a header file and use them rather than magic numbers:
#define MT29F1G_MFR 0x2c /* Micron */
#define MT29F1G_MFR2 0x20 /* numonyx */
#define MT29F1G_ID 0xa1 /* x8, 1GiB */
#define MT29F2G_ID 0xba /* x16, 2GiB */
#define MT29F4G_ID 0xbc /* x16, 4GiB */

And why does identify_xm_ddr() want to see 0 but k9f1g08r0a.c think micron is 0x2c ? That looks a bit suspicious.

(Code cleanup, if we care: k9f1g08r0a.c:nand_chip() should use the new nand_readid() function.)