Merge or sync with Debian unstable

Bug #1574681 reported by Bryan Quigley
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
winetricks (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Debian has 0.0+20151116-1
Ubuntu has a version from 2014.

This package contains a lot of download links that have expired.

Unfortunately neither the Debian or Ubuntu package works as well as the upstream one. In both cases, I get:
$ winetricks
------------------------------------------------------
wineserver not found!
------------------------------------------------------

Whereas the upstream one gives me a nice menu and just works (It appears this might be related to my prefix being 64 bit, Indeed, winetricks in the archive only works on 32-bit for both Debian and Ubuntu - see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=810658).

If we end up removing it from the archive -

I'm thinking we should still sync just because that gives us one place to land a new version (Debian)..

Changelog:
  * Merge from Debian unstable. (LP: #1393145) Remaining changes:
    - debian/control:
      + Move wine* from Depends to Recommends.
In 99% of cases you want wine installed. The only case you don't is if you're building wine from source and in that case you likely want wintricks from source too.

      + Do not suggest libwine.
Still installs fine with this. As we move to Debians packaging this will be useful again.

    - debian/install:
      + Fix install path for .desktop and .svg file.
    - debian/patches/10-option-gui.patch:
      + Dropped to get start with GUI worked.
These are both true issues in Debian. Need to report there.. The gui item might be something they prefer that way.

Discussion: https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2016-April/016463.html.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Is there an upstream package we can build from source and get into the archive? Do you have a link to it?

Revision history for this message
Austin English (austinenglish) wrote :

Yes, it's currently hosted on github at https://github.com/Winetricks/winetricks/

Revision history for this message
Daniel Holbach (dholbach) wrote :

Maybe somebody could prepare a candidate revision for yakkety (16.10) and upload it to a PPA, so it can be reviewed and included?

Revision history for this message
Austin English (austinenglish) wrote :

I can't, I'm busy with other stuff and don't have easy access to Ubuntu.

Revision history for this message
Austin English (austinenglish) wrote :

That said, it should just be a matter of updating the version in the package, not much has changed from a packaging perspective that I can think of, with one notable exception: add an Suggests for torify (It can download things via tor for censored networks).

Other than that, verify deps against the ones listed in the early comments.

Revision history for this message
Austin English (austinenglish) wrote :

Also potentially suggest aria2c, for faster downloads (curl/wget still supported as well)

Revision history for this message
Graham Inggs (ginggs) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in winetricks (Ubuntu):
status: New → Confirmed
Revision history for this message
Joseph Bisch (josephbisch) wrote :

I'm the winetricks maintainer for Debian. I'll look at the issues raised in the changelog section of the bug description, but in the meantime, I want to point out that there is a newer version of winetricks packaged on mentors.debian.net[0]. It adds the suggests on aria2 and tor as well. I'm currently looking for a sponsor to get it into Debian.

[0] - https://mentors.debian.net/package/winetricks

Revision history for this message
Joseph Bisch (josephbisch) wrote :

Winetricks 0.0+20160425-1 has been uploaded to Debian unstable. It is currently the latest release from Winetricks upstream. The Debian bug linked to from this bug should be fixed in Debian unstable now.

I'll look at fixing those two issues that were mentioned in this bug in the next version of winetricks in Debian. The GUI patch was there when I adopted the package and I was relatively new to packaging, so I left it the way it was. I don't see any reason to leave it in Debian now, other than that removing it might surprise Debian users who are used to the patch. The install paths should definitely be fixed in Debian.

Revision history for this message
Bryan Quigley (bryanquigley) wrote :

Thanks Joseph! For both the update and a good plan to close the delta :)
Thanks Graham! For doing the merge with the latest unstable update.

This bug is now fixed in yakkety, so closing.

Changed in winetricks (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.