Comment 24 for bug 1530229

Revision history for this message
In , Rafał Mużyło (galtgendo) wrote :

Thanks for the credit, though I don't consider it fully earned.

Anyway, the patch builds - it might even work, but I'm not sure which apps were using it.

Only one I'm sure about isn't working (is just crashing) due to bug 9127...

I've tried to cargo-cult around it using some of YUV pieces, but it looks like I just don't sufficiently understand DirectShow.

(on that note: how do you get width/height/rate from MEDIASUBTYPE_MPEG1System ? you randomly pick one of the streams ?)

Though a couple minor points:

- it seems new GST_QUERY_ types should be added to switch, query_function, so that "Unknown query" are printed only for *unknown* values

- not quite sure if it's generic or app specific, but sometimes if a video fails to play due to a missing codec ("err:msvideo:ICLocate Required media codec 'vidc I420' not found!), on a retry the app crashes

- not sure if it can be helped, but I wonder if some kind of null input can be provided, so that the apps don't crash if a needed gst plugin isn't installed