Comment 28 for bug 913444

Revision history for this message
In , Olivier Dierick (o-dierick) wrote :

Created attachment 65280
Patchset for wine 4.15

Hello,

The attached file is a patchset and this is a request for comments.

The patchset aims at retaining userdirs symlink/real directories across updates.

It is different from the other proposed patch in that it only creates one symlink when looking for a specific folder.

On prefix creation, the default is still to create symlinks.
If the user unticks the links in winecfg, he gets real directories in the wineprefix. With the patchset, they are retained across updates.

I made a small modification to the 'educated guess' that is used to chose the target of the symlinks:

The old behavior did target the PICTURE, VIDEO and MUSIC symlinks to subdirs of PERSONAL (=My Documents) if they did exists, wherever the PERSONAL folder target to ($HOME/My Documents, XDG documents dir, OSX documents path, '$HOME' or %USERPROFILE%).

The new behavior is that it does that only when PERSONAL really comes from '$HOME/My Documents', no more when PERSONAL comes from XDG or OS X.
XDG and OS X will use the separate PICTURE, VIDEO and MUSIC settings that they define and fallback to PERSONAL if necessary.

I think that people that have setup XDG or use OSX paths want the feature to be consistent for all the folder.

If that change is undesirable, I may provide another patchset with original behavior.

Regards.