Comment 26 for bug 913444

Revision history for this message
In , Gregor Riepl (onitake) wrote :

Probably because the patch hasn't been shaped up, approved and sponsored by someone with commit rights...

I still stand by my comment about modifying the permission mask:
Applications should _not_ preclude any umask set by the user or the system. A directory should be created with 0777 permissions - in most cases this will translate to 0755 due to a suitable 0022 umask. In all other cases, it is wrong to go against the user's wishes and set more restrictive permissions.

If you really think it's necessary to do just that, please move the permission modification to a different patch, as it doesn't contribute to solving the bug here.

Aside from that, I think the patch should be tested thoroughly and accepted.