Comment 465 for bug 371897

(In reply to comment #348)
> (In reply to comment #347)
> > Apparently Wine has again rejected a winepulse patch after Maarten Lankhorst
> > put a bunch of work into improving it in his wine/multimedia.git repo
> > (http://repo.or.cz/w/wine/multimedia.git).
>
> Would you please provide some ground for your statement about rejection of the
> patch?

Alexey,

I only know what I read at the two links that I posted. I have asked for more information on the Ubuntu forum thread, but have not yet received a reply.

I believe the forum post may have been made by Maarten himself (but I am not 100% certain), and it was certainly Maarten who recently added the following comment to his v16 version of the winepulse patch:

-----
+ /* Give one visible warning per session
+ * Sadly wine has chosen not to accept the winepulse patch, so support ourselves
+ */
+ if (!warn_once && (warn_once = CreateEventA(0, 0, 0, "__winepulse_warn_event")) && GetLastError() != ERROR_ALREADY_EXISTS) {
+ FIXME_(winediag)("Winepulse is not officially supported by the wine project\n");
+ FIXME_(winediag)("For sound related feedback and support, please visit http://ubuntuforums.org/showthread.php?t=1960599\n");
+ } else {
+ WARN_(winediag)("Winepulse is not officially supported by the wine project\n");
+ WARN_(winediag)("For sound related feedback and support, please visit http://ubuntuforums.org/showthread.php?t=1960599\n");
+ }
-----

Here is the commit in which that comment was added: http://repo.or.cz/w/wine/multimedia.git/commit/8cb901e61446bd469f89de936133d2918fedbfd1