Comment 134 for bug 357456

Revision history for this message
In , EvilSupahFly (seann-giffin) wrote :

(In reply to Austin English from comment #127)
> (In reply to Giacomo Orlandi from comment #126)
> > (In reply to fjfrackiewicz from comment #125)
> > [...]
> > > > > I submitted the patch to Wine Staging:
> > > > > https://dev.wine-staging.com/patches/132/
> > > > > Let's hope this gets accepted.
> > > >
> > > > It has been accepted into Staging. Yay!
> > >
> > > Shouldn't the status be set to "staging" along with the accepted patchset?
> >
> > The description of the patch above says it's only a workaround to make the
> > apps work until there is a proper fix.
> >
> > I can't see a policy for this in https://wiki.winehq.org/Bugs
> > but I assume that a bug can be marked as "fixed on staging" only if it's a
> > proper fix, even if it hasn't been merged into the main codebase yet because
> > it needs reviewing and some improvements.
>
> That's not such an easy distinction to make. If the fix is proper, it
> wouldn't be in staging anyway, but in vanilla Wine.
>
> If the bug exists in vanilla wine, but not wine-staging, it is reasonable to
> make the status 'STAGED'.
>
> Side note: the staging version is less hacky than the original submission..

The staging version looks good. I'm going to test it this weekend.