Comment 7 for bug 1340604

Revision history for this message
Evan (ev) wrote : Re: [phone] crash files are only uploaded on boot

Stellar work, guys. I do find it odd that this is causing whoopsie to sit around doing nothing, given that online_state defaults to true, but let's assume for a minute that dbus is indeed the problem.

The upstart job doesn't have any non-runlevel service dependencies, so it could conceivably come up before the system bus is started. Coming up before Network Manager should be okay, thanks to dbus service activation.

If we cannot talk to Network Manager, we assume Internet connectivity. This covers the case where NetworkManager or DBus have caught fire. Besides, if we cannot submit a crash file, we'll find out pretty quickly.

However, this code was written before whoopsie was running on phones and I now worry we could end up in a situation where we're trying to send lots of large crash files on a 3G or paid connection.

As much as it pains me to add runtime dependencies to whoopsie, perhaps we should solve this by putting 'start on started dbus' and 'stop on stopping dbus' in the upstart job. What do you guys think? Brian? Does this fix the bug for you, Paul and Joe?