Opening the bookmarks view doesn’t exit find-in-page mode
Bug #1522776 reported by
Olivier Tilloy
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy | ||
Bug Description
This behaviour is inconsistent with what opening the history view does: when opening the history view, if find-in-page was activated, it is deactivated.
Steps to reproduce:
- launch webbrowser-app
- enable find-in-page mode (either from the drawer menu, or with the Ctrl+F keybord shortcut)
- open the bookmarks view (either from the drawer menu, or with the Ctrl+Shift+O keyboard shortcut)
- exit the bookmarks view (click the done button, or press ESC)
Expected result: find-in-page has been deactivated, the address bar is in its normal, idle state.
Current result: find-in-page is still active.
Related branches
lp:~osomon/webbrowser-app/keyboard-shortcut-fixes
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 159 lines (+92/-6)4 files modifiedsrc/app/webbrowser/Browser.qml (+14/-2)
src/app/webbrowser/HistoryViewWide.qml (+2/-4)
tests/autopilot/webbrowser_app/emulators/browser.py (+3/-0)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+73/-0)
| Changed in canonical-devices-system-image: | |
| assignee: | nobody → Bill Filler (bfiller) |
| importance: | Undecided → Medium |
| milestone: | none → ww02-2016 |
| status: | New → In Progress |
| Changed in canonical-devices-system-image: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This bug was fixed in the package webbrowser-app - 0.23+16.
---------------
webbrowser-app (0.23+16.
[ CI Train Bot ]
* New rebuild forced.
* Resync trunk.
[ Olivier Tilloy ]
* Fix 3 autopilot test failures on desktop in narrow mode. (LP:
#1522344)
* Fix multiple keyboard focus/shortcut issues. (LP: #1522776,
#1522783, #1522757, #1522767)
* Replace custom models (HistoryDomainL
HistoryLast
SortFilterModel instances. Remove entirely HistoryTimefram
which was not needed any longer. (LP: #1480947)
* Skip a test that requires HTTPS support in the test suite, which is
lacking for now.
* Update translation template.
-- Olivier Tilloy <email address hidden> Fri, 04 Dec 2015 11:06:50 +0000