Use SortFilterModel for custom models
Bug #1480947 reported by
Olivier Tilloy
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
Medium
|
Bill Filler | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy |
Bug Description
While browsing the UITK documentation, I stumbled upon https:/
webbrowser-app has a number of custom models written in C++ that inherit QSortFilterProx
From a very quick glance, the following models are candidates:
- HistoryDomainModel
- BookmarksFolder
- HistoryDomainLi
This would have the advantage of removing a significant amount of custom C++ code, speeding up build time and unit tests run time.
Related branches
lp:~osomon/webbrowser-app/use-qml-SortFilterModel
- PS Jenkins bot: Approve (continuous-integration)
- Ugo Riboni (community): Approve
-
Diff: 2429 lines (+242/-1360)42 files modifiedsrc/app/webbrowser/CMakeLists.txt (+0/-4)
src/app/webbrowser/HistoryView.qml (+6/-6)
src/app/webbrowser/HistoryViewWide.qml (+12/-7)
src/app/webbrowser/NewTabView.qml (+1/-5)
src/app/webbrowser/NewTabViewWide.qml (+1/-6)
src/app/webbrowser/PreviewManager.qml (+1/-3)
src/app/webbrowser/TopSitesModel.qml (+31/-0)
src/app/webbrowser/history-domain-model.cpp (+4/-5)
src/app/webbrowser/history-domain-model.h (+5/-5)
src/app/webbrowser/history-domainlist-chronological-model.cpp (+0/-55)
src/app/webbrowser/history-domainlist-chronological-model.h (+0/-46)
src/app/webbrowser/history-domainlist-model.cpp (+4/-5)
src/app/webbrowser/history-domainlist-model.h (+6/-6)
src/app/webbrowser/history-lastvisitdate-model.cpp (+0/-141)
src/app/webbrowser/history-lastvisitdate-model.h (+0/-63)
src/app/webbrowser/history-lastvisitdatelist-model.cpp (+45/-7)
src/app/webbrowser/history-lastvisitdatelist-model.h (+1/-0)
src/app/webbrowser/history-model.cpp (+9/-1)
src/app/webbrowser/history-model.h (+2/-1)
src/app/webbrowser/history-timeframe-model.cpp (+0/-98)
src/app/webbrowser/history-timeframe-model.h (+0/-63)
src/app/webbrowser/limit-proxy-model.h (+1/-1)
src/app/webbrowser/top-sites-model.cpp (+0/-60)
src/app/webbrowser/top-sites-model.h (+0/-49)
src/app/webbrowser/webbrowser-app.cpp (+0/-8)
tests/unittests/CMakeLists.txt (+0/-4)
tests/unittests/history-domain-model/tst_HistoryDomainModelTests.cpp (+8/-14)
tests/unittests/history-domainlist-chronological-model/CMakeLists.txt (+0/-13)
tests/unittests/history-domainlist-chronological-model/tst_HistoryDomainListChronologicalModelTests.cpp (+0/-110)
tests/unittests/history-domainlist-model/tst_HistoryDomainListModelTests.cpp (+11/-25)
tests/unittests/history-lastvisitdate-model/CMakeLists.txt (+0/-11)
tests/unittests/history-lastvisitdate-model/tst_HistoryLastVisitDateModelTests.cpp (+0/-138)
tests/unittests/history-lastvisitdatelist-model/tst_HistoryLastVisitDateListModelTests.cpp (+14/-35)
tests/unittests/history-model/tst_HistoryModelTests.cpp (+1/-1)
tests/unittests/history-timeframe-model/CMakeLists.txt (+0/-13)
tests/unittests/history-timeframe-model/tst_HistoryTimeframeModelTests.cpp (+0/-160)
tests/unittests/limit-proxy-model/tst_LimitProxyModelTests.cpp (+79/-60)
tests/unittests/qml/CMakeLists.txt (+0/-3)
tests/unittests/qml/tst_HistoryViewWide.qml (+0/-1)
tests/unittests/qml/tst_QmlTests.cpp (+0/-6)
tests/unittests/top-sites-model/CMakeLists.txt (+0/-13)
tests/unittests/top-sites-model/tst_TopSitesModelTests.cpp (+0/-108)
Changed in webbrowser-app (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Medium |
tags: | added: refactoring |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | Triaged → In Progress |
Changed in canonical-devices-system-image: | |
assignee: | nobody → Bill Filler (bfiller) |
importance: | Undecided → Medium |
milestone: | none → ww02-2016 |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Blocked on bug #1485674.