Thanks for clarifying Olivier.
So a revised use-case would be:
1. Attempt to visit a URL with an active connection, page begins loading.
2. Active connection is lost. Page never finishes loading & 'Network error' page is not shown.
3. User can't ever tap star to favourite entered URL (as the star is never shown).
I think this case means we should consider showing the star even while loading, as well as when loading completes or is not possible:
- The site can be bookmarked with no active connection, from the 'Network error' page (will be the URL as originally entered).
- The site can be bookmarked when connectivity is lost while loading/ page loading cannot be completed (will be the URL as originally entered).
- The site can be bookmarked when loaded (will be the URL reached after the user has been forwarded, for example to a mobile site, etc).
Thanks for clarifying Olivier.
So a revised use-case would be:
1. Attempt to visit a URL with an active connection, page begins loading.
2. Active connection is lost. Page never finishes loading & 'Network error' page is not shown.
3. User can't ever tap star to favourite entered URL (as the star is never shown).
I think this case means we should consider showing the star even while loading, as well as when loading completes or is not possible:
- The site can be bookmarked with no active connection, from the 'Network error' page (will be the URL as originally entered).
- The site can be bookmarked when connectivity is lost while loading/ page loading cannot be completed (will be the URL as originally entered).
- The site can be bookmarked when loaded (will be the URL reached after the user has been forwarded, for example to a mobile site, etc).
Sound reasonable?