Comment 3 for bug 909189

Revision history for this message
Julian Taylor (jtaylor) wrote :

thanks for your contribution to ubuntu.

I modified the debdiff a bit adding this:
  * wrap-and-sort debian/
  * convert copyright to dep5 format
  * use dh_python2 instead of pysupport

please review the changes I made and check if the package still works correctly. the largest change is the use of dh_python2 instead of the deprecated pysupport.

I don't like the uses of os.system in the source e.g.
os.system(wakeup_script + " $USER " + re.search("\d+",folder).group(0) + " test &")
and many more.
I'm not sure if those can be used to for priviledge escalations but I still prefer those unsafe system calls to be fixed by using the subprocess module (without shell=True) before I upload this.