Comment 11 for bug 1297051

Revision history for this message
boon (boon-9ft1s) wrote :

I've tested the second patch.

RI now works.

I tried OSC ... ST in both the unmixed C1 form and the unmixed ESC form. They both work.

Hunting around the internet, the unmixed ESC form seems more common. I am not worried that they wouldn't work in a mixed form. That would be fairly perverse. I am no expert on the spec but if the C1 forms are intended to be "equivalent" to the corresponding ESC forms then the mixed forms _ought_ to work but I am not hassling anyone to support that.

The C1 form of CSI still works i.e. no regression.

Thanks for your work !

I will wait until it appears in a Ubuntu release.

*****

I noticed a couple of other issues.

1. Resizing of the terminal by the remote host does not work by default. I was only doing basic resizing (such as would work on a real terminal).

ESC[?3l should get width 80 (that sequence ends with a lower case letter L), and
ESC[?3h should get width 132

(or the equivalent CSI forms).

Looking at the source, it is necessary to send ESC[?40h before either of the above resize sequences will work. Not sure whether that's correct behaviour but I am happy to do that so am adding this comment only in case it helps someone else.

2. Answerback does not work

The way answerback is supposed to work is that the remote host sends an ENQ character (CTRL/E i.e. character with value 0x05) and the terminal is supposed to send whatever string it has been configured to send, where that configuration should allow the user to configure to send control characters so that, at least, the user can configure to send a trailing carriage return.

(For security reasons, the remote host should not be allowed to set the answerback message or at least not by default i.e. not without the user configuring to allow that. An escape sequence exists for the purpose of setting the answerback message from the remote host but I think it is not supported by this emulator anyway.)

Looking at the source, it seems as if it recognises the ENQ but deliberately sends no response.