| 2016-02-12 00:57:46 |
Shaheed Haque |
bug |
|
|
added bug |
| 2016-02-12 00:57:46 |
Shaheed Haque |
attachment added |
|
Proposed patch https://bugs.launchpad.net/bugs/1544802/+attachment/4569739/+files/vpnc-script.diff |
|
| 2016-02-12 01:19:47 |
Shaheed Haque |
description |
The /usr/share/vpnc-scripts/vpnc-script handles updates to the default route using two different codepaths. In one codepath, the command "ip route replace" is used to update the original default route with new one (and to restore it later). The replace command in the update case does not work if the original route default route has non-standard attributes. For example, an original default route like this:
$ sudo ip route
default via 192.168.1.254 dev wlp3s0 proto static metric 600
169.254.0.0/16 dev wlp3s0 scope link metric 1000
192.168.1.0/24 dev wlp3s0 proto kernel scope link src 192.168.1.85 metric 600
cannot be simply "ip route replace"d by a command of the form "ip route replace dev <foo>". Also, the present logic to save and then restore the original rute is broken because not all the route attributes are preserved AND the replacement attributes don't match the attributes of the new default route.
The attached patch addresses both these problems. |
The /usr/share/vpnc-scripts/vpnc-script handles updates to the default route using two different codepaths. In one codepath, the command "ip route replace" is used to update the original default route with new one (and to restore it later). The replace command in the update case does not work if the original route default route has non-standard attributes. For example, an original default route like this:
$ sudo ip route
default via 192.168.1.254 dev wlp3s0 proto static metric 600
169.254.0.0/16 dev wlp3s0 scope link metric 1000
192.168.1.0/24 dev wlp3s0 proto kernel scope link src 192.168.1.85 metric 600
cannot be simply "ip route replace"d by a command of the form "ip route replace dev <foo>". Also, the present logic to save and then restore the original rute is broken because not all the route attributes are preserved AND the replacement attributes don't match the attributes of the new default route.
The attached patch addresses both these problems.
The software versions in use are:
$ dpkg-query -l | egrep 'vpnc-scripts|iproute'
ii iproute 1:4.1.1-1ubuntu1 all transitional dummy package for iproute2
ii iproute2 4.1.1-1ubuntu1 amd64 networking and traffic control tools
ii vpnc-scripts 0.1~git20140806-1 all Network configuration scripts for VPNC and OpenConnect |
|
| 2016-02-12 01:20:27 |
Shaheed Haque |
description |
The /usr/share/vpnc-scripts/vpnc-script handles updates to the default route using two different codepaths. In one codepath, the command "ip route replace" is used to update the original default route with new one (and to restore it later). The replace command in the update case does not work if the original route default route has non-standard attributes. For example, an original default route like this:
$ sudo ip route
default via 192.168.1.254 dev wlp3s0 proto static metric 600
169.254.0.0/16 dev wlp3s0 scope link metric 1000
192.168.1.0/24 dev wlp3s0 proto kernel scope link src 192.168.1.85 metric 600
cannot be simply "ip route replace"d by a command of the form "ip route replace dev <foo>". Also, the present logic to save and then restore the original rute is broken because not all the route attributes are preserved AND the replacement attributes don't match the attributes of the new default route.
The attached patch addresses both these problems.
The software versions in use are:
$ dpkg-query -l | egrep 'vpnc-scripts|iproute'
ii iproute 1:4.1.1-1ubuntu1 all transitional dummy package for iproute2
ii iproute2 4.1.1-1ubuntu1 amd64 networking and traffic control tools
ii vpnc-scripts 0.1~git20140806-1 all Network configuration scripts for VPNC and OpenConnect |
The /usr/share/vpnc-scripts/vpnc-script handles updates to the default route using two different codepaths. In one codepath, the command "ip route replace" is used to update the original default route with new one (and to restore it later). The replace command in the update case does not work if the original route default route has non-standard attributes. For example, an original default route like this:
$ sudo ip route
default via 192.168.1.254 dev wlp3s0 proto static metric 600
169.254.0.0/16 dev wlp3s0 scope link metric 1000
192.168.1.0/24 dev wlp3s0 proto kernel scope link src 192.168.1.85 metric 600
cannot be simply "ip route replace"d by a command of the form "ip route replace dev <foo>". Also, the present logic to save and then restore the original rute is broken because not all the route attributes are preserved AND the replacement attributes don't match the attributes of the new default route.
The attached patch addresses both these problems.
The software versions in use are up-to-date Wily with:
$ dpkg-query -l | egrep 'vpnc-scripts|iproute'
ii iproute 1:4.1.1-1ubuntu1 all transitional dummy package for iproute2
ii iproute2 4.1.1-1ubuntu1 amd64 networking and traffic control tools
ii vpnc-scripts 0.1~git20140806-1 all Network configuration scripts for VPNC and OpenConnect |
|
| 2016-02-12 04:24:50 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2016-02-12 04:24:58 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
