Support default route with non-default attributes

Bug #1544802 reported by Shaheed Haque
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vpnc-scripts (Ubuntu)
New
Undecided
Unassigned

Bug Description

The /usr/share/vpnc-scripts/vpnc-script handles updates to the default route using two different codepaths. In one codepath, the command "ip route replace" is used to update the original default route with new one (and to restore it later). The replace command in the update case does not work if the original route default route has non-standard attributes. For example, an original default route like this:

$ sudo ip route
default via 192.168.1.254 dev wlp3s0 proto static metric 600
169.254.0.0/16 dev wlp3s0 scope link metric 1000
192.168.1.0/24 dev wlp3s0 proto kernel scope link src 192.168.1.85 metric 600

cannot be simply "ip route replace"d by a command of the form "ip route replace dev <foo>". Also, the present logic to save and then restore the original rute is broken because not all the route attributes are preserved AND the replacement attributes don't match the attributes of the new default route.

The attached patch addresses both these problems.

The software versions in use are up-to-date Wily with:

$ dpkg-query -l | egrep 'vpnc-scripts|iproute'
ii iproute 1:4.1.1-1ubuntu1 all transitional dummy package for iproute2
ii iproute2 4.1.1-1ubuntu1 amd64 networking and traffic control tools
ii vpnc-scripts 0.1~git20140806-1 all Network configuration scripts for VPNC and OpenConnect

Tags: patch
Revision history for this message
Shaheed Haque (srhaque-i) wrote :
description: updated
description: updated
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Proposed patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Mike Miller (mtmiller) wrote :

Hi Shaheed, would you mind sending your patch to <email address hidden>? Please see http://www.infradead.org/openconnect/contribute.html for contribution guidelines.

Thanks!

Revision history for this message
Shaheed Haque (srhaque-i) wrote : Re: [Bug 1544802] Re: Support default route with non-default attributes
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers