Comment 1 for bug 2063841

Revision history for this message
Andreas Hasenack (ahasenack) wrote (last edit ):

I understand this is urgent, but this SRU is missing some details.

a) Upstream still has the warning[1] in the "news flash" on the top right of the page, telling users to not upgrade to 7.0.16. In the 7.0.16 changelog[2] page, though, there is no further information.

b) I browsed their bug database, and mailing lists, particularly right after the 7.0.16 announcement, and found no patch or follow-up

c) While not required, the patch in the SRU has no DEP-3 headers. Where is it coming from? I think in this case, given the little amount of information available elsewhere, it would be best if it had such headers. Or, instead, the SRU description of the bug could have more details: upstream bug, upstream commit, perhaps a link to some discussion. Is this fix enough? I found another place in the same file where the same variable is declared, and it does not have the 2* change. Maybe not needed there, but then again, there is no explanation about this patch.

While we are at it, if a new upload would happen, it could also have these changes:
- run update-maintainer
- while at it, the version could be changed to the SRU format, which in this case, would be 7.0.16-dfsg-2ubuntu0.1

1. https://www.virtualbox.org/
2. https://www.virtualbox.org/wiki/Changelog-7.0#v16