vala doesn't build with unit test

[Julien Lavergne]

vala doesn't build on Ubuntu because the fail of a unit test fail the entire build. Build log : http://launchpadlibrarian.net/36070751/buildlog_ubuntu-lucid-i386.vala_0.7.8-2_FAILEDTOBUILD.txt.gz

  /dbus/basic-types/server: FAIL

** CRITICAL **: file /build/buildd/vala-0.7.8/tests/_test/main.c: line 13738: uncaught error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
aborting...
dbus.basic_types.server.check: line 4: 6149 Aborted ./test /dbus/basic-types/server
  /dbus/arrays/server: FAIL

** CRITICAL **: file /build/buildd/vala-0.7.8/tests/_test/main.c: line 15613: uncaught error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
aborting...
dbus.arrays.server.check: line 4: 6157 Aborted ./test /dbus/arrays/server
  /dbus/async/server: FAIL

** CRITICAL **: file /build/buildd/vala-0.7.8/tests/_test/main.c: line 16975: uncaught error: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
aborting...
dbus.async.server.check: line 4: 6165 Aborted ./test /dbus/async/server
  /dbus/bug596862: OK
3 of 59 tests failed

[Andrew Starr-Bochicchio (andrewsomething)]

The latest Debian revision specifically make test failures fatal for Ubuntu. Is this actually something we want?

vala (0.7.8-2) unstable; urgency=low

  * debian/control:
    + Remove Mathias Hasselmann from Uploaders, he did the initial packaging
      for Ubuntu but was not involved with the Debian package at all.
  * debian/control,
    debian/rules:
    + Make unit test failures fatal on Ubuntu.

--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,8 @@
 DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)

+DISTRO = "$(shell lsb_release -si)"
+
 configure_flags += \
        --prefix=/usr \
        --mandir=/usr/share/man \
@@ -83,7 +85,11 @@ build-stamp: configure-stamp
        touch $@

 check-stamp: build-stamp
+ifeq ($(DISTRO),"Ubuntu")
+ make $(DEB_MAKE_PARALLEL) check
+else
        make $(DEB_MAKE_PARALLEL) check || true
+endif
        touch $@

 install-stamp: build-stamp check-stamp

[Andrew Starr-Bochicchio (andrewsomething)]

To answer my own question from above, apparently yes. See: Bug #374151

[Julien Lavergne (gilir)]

But the MIR was canceled, I don't see any reason to stay with this,
especially if nobody fix it (it's FTBFS since 3 weeks !).
There is a new release of Vala (0.7.9), let's wait and test it when
Debian will package it, and disable the test if it's still a problem.

Le vendredi 18 décembre 2009 à 03:03 +0000, Andrew Starr-Bochicchio a
écrit :
> To answer my own question from above, apparently yes. See: Bug #374151
>

[Julien Lavergne (gilir)]

Still a problem with 0.7.9. But it seems to fail because dbus is not started when building the package, so all dbus checks can't pass. If tests runs locally, it's working.

[Andrew Starr-Bochicchio (andrewsomething)]

I'm keeping this bug open, as the unit test still fail on the buildds. But as, with Julien's upload, they no longer cause vala to FTBFS, I'm lowering the importance.

vala (0.7.9-0ubuntu1) lucid; urgency=low

  * New upstream release.
  * debian/rules: Don't make unit test failures fatal to fix FTBFS. It was
    needed if vala need to enter main but it's not the case for now.
    (See #374151)
 -- Julien Lavergne < <email address hidden> > Wed, 30 Dec 2009 20:58:03 +0100

[Martin Pitt (pitti)]

Ah, I finally tracked it down -- it's fakeroot! "make check" works, "fakeroot make check" breaks the D-Bus tests. I'll see how to circumvent that.

[Launchpad Janitor (janitor)]

This bug was fixed in the package vala - 0.7.10-1ubuntu3

---------------
vala (0.7.10-1ubuntu3) lucid; urgency=low

  * debian/rules: Do not run the test suite under fakeroot, it breaks the
    D-Bus tests. Make the build fail on test suite failure again.
    (LP: #496312)
 -- Martin Pitt <email address hidden> Thu, 04 Mar 2010 21:02:40 +0100