SO/PO should be allowed to be cancelled by un-linking the concerned packing!

Bug #596862 reported by Joël Grand-Guillaume @ camptocamp
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Status tracked in Trunk
5.0
Fix Released
High
Unassigned
Trunk
Fix Released
High
Unassigned

Bug Description

Hi,

I just realized that with the new check on the last version it's just impossible to cancel a SO when his picking has already been confirmed !!!

I mean, this should not appear in a normal flow, I agree, but what to do when you're facing this !??

To reproduce :

1. Create a SO with 1 line (no matter the configuration)
2. Confirm it, go to the packing and confirmed it (force if necessary)
3. Go back to the SO, try to cancel => It says you must cancel the packing first !
=> Normal
4. Goto to the packing, you cannot cancel it, there is no button ! The workflow doesn't allow to cancel the "done" packing !
=> Can be normal...
5. Ok, so now you try to Delete this "done" packing in order to cancel your SO and it's not possible anymore !!! Says you cannot delete a done packing

So, you cannot cancel, you cannot delete the packing... But you need one of those solutions to delete your SO !!

We do need something here to be able to cancel the SO, whatever it is.

I'll suggest to enable the workflow transition from Done to Cancel state into packing. Doing this, we'll be able to ensure who's doing that through "role" security.

Thanks,

Joël

Changed in openobject-addons:
milestone: none → 5.0.12
Changed in openobject-addons:
importance: Undecided → High
summary: - Bug on sales flow : we cannot cancel a SO anymore
+ Regression: on sales flow : we cannot cancel a SO anymore
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote : Re: Regression: on sales flow : we cannot cancel a SO anymore

Hello Experts,

We would like to know your views here.

@Joël , Can we use return packing wizard?

But there is still a problem, that we cannot remove DONE picking.

What I tried at my end is, One picking was done, I Returned it, made it DONE,which cancelled the effect of main picking. And I then created return of the Returned picking which gave me my first picking back...

Well, this was just a trick, which didn't work due to we cannot remove done packing.

I request experts to share their opinions here, what could be done to achieve the aim to cancel the SO.

Thanks for your time.

Revision history for this message
Ferdinand (office-chricar) wrote :

IMHO this is a general problem

It must be possible to cancel/revert "ALL" of SO/PO/Picking/Invoice - but still conforming to accounting principles.
Currently every now and then I have to revert unwanted / wrong pickings manually because none of the methods provided are sufficient.

So if some object (specially Picking and Invoice) has the status "done" (or paid), we have to create a picking/invoice with reverted moves.
then the original and reverted object can (or must be !) be "reconciled" - to get a status a special status "canceled after done".

it is important not to break the accounting rules - everything must be documented and no gaps must exist in the numbered documents.

I specially emphasise that this method will and must also create correct accounting moves.

What remains open is the evaluation "cost of goods sold".
We should agree that reverting should use the same values (move_value_cost and move_value_sale in my branch) but this creates a problem if the average price has changed meanwhile or if the total qty available became 0 (zero).
So I suggest to create additional move_lines in accounting which accommodate for the difference between move_value_cost of the original and reverted moves.

Revision history for this message
Ferdinand (office-chricar) wrote :

I forgot
if all pickings have the status "canceled" or "canceled after done" a salesorder PO could also be canceld.

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

The suggestion of using return packing is a good one. It'll someway cancel the accounting move (by generation of reversed entries), so we're not running into trouble with accounting principle (do you confirm this Ferdinand ?).

The things is : for know, if I return a packing and confirm the return, I still cannot cancel the SO (or I may be miss something !?). We might be able to say something like : If a SO has been picked, then we cannot cancel it, but if goods are returned, so then we should be able to cancel the SO, make it different, an re-confirm it again.

That way, Accounting is OK, modification of the SO is possible (to adjust quantities, or whatever), and the "re-confirmation" of the SO will regenerate the new packing and allow the delivery of the good goods as well as regenerate the right accouting entries !

What do you think ?

Regards,

Joël

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote : Re: [Bug 596862] Re: Regression: on sales flow : we cannot cancel a SO anymore
Download full text (4.1 KiB)

I don't think it is a regression. It has been like that from beginning. You
can not cancell done moves, you can not erase moves at less it is on draft
mode.

So... if you make a picking done, it's not possible erasing picking. This is
a little bit extrange case because why do you need cancelling a done move? I
say... if you really sent goods to customer, it's right picking is done and
can not be cancelled.
If your picking comes back from customer you will need registering this new
entry picking. Marking it as related to first picking. This is right.

If you really are not sending goods to customer... ¿Why do you make moves
done?

By the other side:

   - It should be possible erasing Cancelled moves. Only draft AND CONFIRMED
   moves could be set to cancelled. This way, if move is not done, you could
   cancel and erase invalid moves. Today all cancelled moves are staying on
   database for ever and ever. This should be perfectly possible because
   confirmed moves are not generating accounting moves, if I'm not mistaken.
   - For done moves, I think it's right generating an inverse move to
   "unmake" the made movement.

Joël: you are right when you say if I return a packing and confirm the
return, I still cannot cancel the SO
But there is a "behind door" to make possible erasing a picking with done
moves and this is, opening the move directly on move lines and erasing pack
number from the one2many field. Once all lines are "not included" on a
picking you can erase the picking and come back the order to draft status...
It's not very "pretty" but it works.

2010/6/24 Joël Grand-Guillaume @ CampToCamp <
<email address hidden>>

> Hi,
>
>
> The suggestion of using return packing is a good one. It'll someway cancel
> the accounting move (by generation of reversed entries), so we're not
> running into trouble with accounting principle (do you confirm this
> Ferdinand ?).
>
> The things is : for know, if I return a packing and confirm the return,
> I still cannot cancel the SO (or I may be miss something !?). We might
> be able to say something like : If a SO has been picked, then we cannot
> cancel it, but if goods are returned, so then we should be able to
> cancel the SO, make it different, an re-confirm it again.
>
> That way, Accounting is OK, modification of the SO is possible (to
> adjust quantities, or whatever), and the "re-confirmation" of the SO
> will regenerate the new packing and allow the delivery of the good goods
> as well as regenerate the right accouting entries !
>
> What do you think ?
>
> Regards,
>
> Joël
>
> --
> Regression: on sales flow : we cannot cancel a SO anymore
> https://bugs.launchpad.net/bugs/596862
> You received this bug notification because you are subscribed to
> OpenObject Addons.
>
> Status in OpenObject Addons Modules: New
>
> Bug description:
> Hi,
>
>
> I just realized that with the new check on the last version it's just
> impossible to cancel a SO when his picking has already been confirmed !!!
>
> I mean, this should not appear in a normal flow, I agree, but what to do
> when you're facing this !??
>
> To reproduce :
>
> 1. Create a SO with 1 line (no matter the configuration)
> 2. Confir...

Read more...

Revision history for this message
Jan Verlaan (jan-verlaan) wrote : Re: Regression: on sales flow : we cannot cancel a SO anymore

Like Ana stated, this is not a regression, it has been from the beginning. I.m.h.o. the current functionality is correct. As a picking is "Done" financial transactions are booked in a period. Also when goods are shipped regarding a specific sales order that sales order can and shouldn't be canceled anymore.
The only way one will have is to receive the goods back with a return packing, including the financial transaction, perhaps in the next period! Those can be reconciled.

I do agree that a user could take a picking-order that seems the wrong one afterward. Right now it is a nightmare to correct this. It would be good to have a function that could reverse the packing, based on authorization/user rights.

Regarding the notice about the possible different price taken for the return packing, that would not occur if one generate the return packing from the original packing. That one is solved about 3 months ago if I'm right, for both standard as also in account_anglo_saxon module when price differences are booked.

summary: - Regression: on sales flow : we cannot cancel a SO anymore
+ on sales flow : we cannot cancel a SO when picking is done.
Revision history for this message
Ferdinand (office-chricar) wrote : Re: on sales flow : we cannot cancel a SO when picking is done.

@Joël: yes - return packing does it, but IMHO the last time the user messed it up somehow, the corresponding invoice hasn't got the right sign. may be they didn't choose "return invoice" but "invoice". Have to check to reproduce.

IMHO it would be desirable to distinguish between return shipments (goods have been moved) and canceled shipments (goods haven't been moved).

@Ana: do not ask why users make errors - they just do ;-) whatever is possible and not forbidden - the software has to handle it correctly.
We have troubles with internal stock locations at customers - we sometimes get "wrong" data reported manually and discover it to late (when the packing is "done").

as Jan put it - correcting it is a nightmare and does probably not conform to accounting principles

Revision history for this message
Jan Verlaan (jan-verlaan) wrote :

I can imaging that a possible solution could be;

if shipped goods - returned goods = 0 AND invoices are all processed resulting in value equals 0 then
     SO can be canceled (not deleted)
else
     SO can NOT be canceled
     if shipped goods - returned goods <> 0 then
          message = There are still goods shipped incl. packing numbers
    if invoices not processed then
         message = There are still draft or open invoices, incl numbers

The idea is that if all goods are returned and all corresponding invoices are processed the sum result is zero for product quantities and purchase or sales amount.
If this is not the case, e.g. shipping fees exist on invoice, the SO can not be canceled and a new SO could be generated.

summary: - on sales flow : we cannot cancel a SO when picking is done.
+ Regression on sales flow : we cannot cancel a SO when picking is done.
summary: - Regression on sales flow : we cannot cancel a SO when picking is done.
+ Regression on sales flow, no way to cancel SO anymore
Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Hi,

First of all thank you all for your position. I confirm this is a regression ! Before that last release, we wasn't able to cancel a SO without canceling or deleting the packing : you're right. But since then, you're not able to cancel or delete the packing anymore !! So you cannot cancel the SO as well.

@ana : It could be a simple error, like people already packed the goods (so packing is done, not delivery). And we're not able to correct the situation : this is someway "unacceptable"...

I agree with Jan Verlaan, The suggested conditions at #8 sounds good to me. So when we want a SO to be canceled, we have to be sure the goods are returned (or cancelled) & the invoice is cancelled or not generated or balanced with a revert one.

So, do we all agree on :

- Done packing cannot be cancelled or deleted

- We should be able to use the return packing to revert stock move & account move (account move generated by the stock move, account move from the invoice is another story).

- SO must be cancelled in a way or another, the best way to deal with seems suggested on #8

At the end, I can cancel my SO if I cancel the packing or return the Done one AND invoice aren't generated or Invoice result in a value equals 0.

Are you alright with that ?

Regards,

Revision history for this message
Jan Verlaan (jan-verlaan) wrote :

I can agree with this flow.

All true It would be very very handy to add a cancel button on the picking for mistaken pickings (where people do work, mistakes are happening) that could revert a picking if the related invoice is in draft state.

Revision history for this message
Borja López Soilán (NeoPolus) (borjals) wrote :

I think the users should always be able to "undo". Users as human, so by definition they make mistakes.

There are complex cases that should be un-done by hand on several steps (i.e. you shouldn't be able to simply cancel an invoice that has been paid), but we should make sure that this use cases are covered and can be worked around (i.e. you can unreconcile a paid invoice and then cancel it).

So, if a user makes a mistake and confirms a picking that shouldn't have been confirmed, he should be able to 'go back' either canceling the picking (if no workflow is affected) or (if confirming the picking affected other document's, like an invoice, workflows) making an inverse/return/refund movement.

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

You all are right. Users make mistakes and it should be possible reverting or "undo" badly made steps on a workflow, so... why not thinking about related actions on cancelling picking?
I think the most usefull functionality could be to make possible going back from cancelled status to confirmed / draft status on a picking analyzing all possible statuses and actions on related objects.

This is... Make a SO, confirm, creates a picking. Don't make moves done simply erase the picking... you could see that stock moves are cancelled not erased. Why? Make the SO come back to draft and confirm again. A new picking is created an new moves are created. If you cancel the first moves and they are there... why don't reactivate and rewrite existing moves instead of creating new ones? I can't see the objetive of this way of working.

Now.. go to an invoice. Confirm. Account moves are created. Now "allow cancelling moves on journal". Cancel the invoice, go back the invoice to draft. The account moves are generated and erased. This is a similar situation. Why is different on picking?

The only thing I try to say is that picking is the only critical object you can't make to go back on workflow. I think there is more as complicated as this one that is posible to revert. So I think we should make a complete analisys to try to include this new step on workflow instead of making a patch or manual buttons or something strange that for sure would break another thing. IMHO.

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

Alright, I came back from OpenERP SA Belgium and have discussed this issue with Fabien. For the stable release, we suggest to add the sale_id field in the out going packing and make it editable (for now it's read-only). So user can manually detach the outgoing packing from the SO, return it with the return packing wizard, and cancel the related SO.

This way, stock are alright and you can cancel the SO.

For the next version 6.0, we'll need something "cleaner" and a workflow to allow the cancelation of the SO would be nice. This is a complex case which need to be discussed with Fabien and the manufacturing/service experts.

I attache the little patch to allow the cancellation in v. 5.0.

Regards,

Joël

Changed in openobject-addons:
status: New → Confirmed
Revision history for this message
Grzegorz Grzelak (OpenGLOBE.pl) (grzegorz-og.pl) wrote :

So please let me add some points for next version with more clear situation happening in reality:

You create SO, send part of goods making outgoing picking done. And for some reason you agree with customer to stop sending goods of this SO. He pays you only for sent goods and you want to close SO. Now SO waits for full shipment and invoicing. It should be a wizard to close SO when shipment = invoicing. SO could have usual "done" state or some "exceptional done". But for sale report it should show just real sale from shipment not from SO.

The same situation you can encounter on purchase site.

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

Joel... I understand nothing about the solution of detach manually packing from SO.

You can cancel the SO, but packing is still done, so I think you have to revert it manually using return packing button wich is not very "pretty". Otherway, your move stays done when you really did not send goods.

Afterwards if you detach SO and cancel and make it draft, on confirming, you will generate another packing to be done, so you are having 3 stock moves for same goods instead of having only the correct one.

IMHO it is not the correct solution yet.

Where is the problem of deleting the stock move or thinking about the workflow of doing it correctly? I don't understand very well the complexity of doing it in right way without generating incorrect moves...

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote :

Sorry... I forgotted saying that same solution should be implemented for sales and purchases. We have got same problem on purchases...

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

@Ana

Detaching the Packing from the SO will allow you to cancel it. Your're right saying the packing is still done, that's why you need to return it with the "return packing" wizard. Confirming the SO again will generate another packing with the right quantities for example.

I think this is absolutely the right solution :

1. First, it doesn't change any flow, so it's "doable" on the stable version. Fabien won't ear anything about changing the workflow or any other solutions which will change or modify the functionnalities in the stable version. I must admit I agree with him. So this is the main reason.

2. It's not a problem to have the historical stock move (3 in this case). You do it like this also in finance by creating a reverse move instead of deleting the original one.

3. Changing the workflow (or deleting the stock move) is a VERY complex task which has a lot of impact. We though about it for the 6.0 version with Fabien and Quentin, but we couldn't achieve a good one. In other system as well it's forbidden to easily cancel a SO when packing is done, and this is because of good reason.

Well, I must say it's a good idea to make the same solution for PO and SO at least : here you get a good point ;) !

@everyone

I suggest to adapt the view of every packing (in, out, internal,...), so it'll be possible to manually revert a wrong operation done on packing in the Sale AND Purchase flow.

Regards,

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote : Re: [Bug 596862] Re: Regression on sales flow, no way to cancel SO anymore
Download full text (3.4 KiB)

OK Joël!!
You are right. At less we will have a solution to revert packings on 5.0.

I totally agree that is not possible touching actual functionality on 5.0!!
I also agree that the right workflow definition for reverting packings
should be included on next stable version.

Thank you very much for your clean explanation!!

2010/7/7 Joël Grand-Guillaume @ CampToCamp <
<email address hidden>>

> @Ana
>
> Detaching the Packing from the SO will allow you to cancel it. Your're
> right saying the packing is still done, that's why you need to return it
> with the "return packing" wizard. Confirming the SO again will generate
> another packing with the right quantities for example.
>
> I think this is absolutely the right solution :
>
> 1. First, it doesn't change any flow, so it's "doable" on the stable
> version. Fabien won't ear anything about changing the workflow or any
> other solutions which will change or modify the functionnalities in the
> stable version. I must admit I agree with him. So this is the main
> reason.
>
> 2. It's not a problem to have the historical stock move (3 in this
> case). You do it like this also in finance by creating a reverse move
> instead of deleting the original one.
>
> 3. Changing the workflow (or deleting the stock move) is a VERY complex
> task which has a lot of impact. We though about it for the 6.0 version
> with Fabien and Quentin, but we couldn't achieve a good one. In other
> system as well it's forbidden to easily cancel a SO when packing is
> done, and this is because of good reason.
>
> Well, I must say it's a good idea to make the same solution for PO and
> SO at least : here you get a good point ;) !
>
> @everyone
>
> I suggest to adapt the view of every packing (in, out, internal,...), so
> it'll be possible to manually revert a wrong operation done on packing
> in the Sale AND Purchase flow.
>
> Regards,
>
> --
> Regression on sales flow, no way to cancel SO anymore
> https://bugs.launchpad.net/bugs/596862
> You received this bug notification because you are subscribed to
> OpenObject Addons.
>
> Status in OpenObject Addons Modules: Confirmed
>
> Bug description:
> Hi,
>
>
> I just realized that with the new check on the last version it's just
> impossible to cancel a SO when his picking has already been confirmed !!!
>
> I mean, this should not appear in a normal flow, I agree, but what to do
> when you're facing this !??
>
> To reproduce :
>
> 1. Create a SO with 1 line (no matter the configuration)
> 2. Confirm it, go to the packing and confirmed it (force if necessary)
> 3. Go back to the SO, try to cancel => It says you must cancel the packing
> first !
> => Normal
> 4. Goto to the packing, you cannot cancel it, there is no button ! The
> workflow doesn't allow to cancel the "done" packing !
> => Can be normal...
> 5. Ok, so now you try to Delete this "done" packing in order to cancel your
> SO and it's not possible anymore !!! Says you cannot delete a done packing
>
> So, you cannot cancel, you cannot delete the packing... But you need one of
> those solutions to delete your SO !!
>
> We do need something here to be able to cancel the SO, whatever it is.
>
> I'll suggest to e...

Read more...

Revision history for this message
Vincent Renaville@camptocamp (vrenaville-c2c) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Hello,

I have made some improvements of the Joel's patch, I have add a link on sale order on each packing view.
I hope this will help.

Vincent

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

This is a good idea, but to be perfect we need :

- Correct the picking view from SO directly and add the sale_id field
- Correct the view from menu Stock -> out picking and add the sale_id field (done in my patch)
- Correct the view from menu Stock - Incoming picking and add the purchase_id field
- The field purchase_id of stock.picking must be "writable" as for sale_id
- Correct the view called from purchase order through "Packing" link and add the purchase_id field

Then will have a perfectly handled solution :

- Same for PO and SO
- Access from all views (direct / link and form related menu)

Thanks,

Changed in openobject-addons:
milestone: 5.0.12 → 5.0.13
status: Confirmed → In Progress
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Vincent,

We are working on this and will attach a suitable patch today.
Your patch is not acceptable as we cannot add sale_id field in stock/stock_view.xml. The fields comes into existence after the installation of sale module.

Hope it is clear.

Thanks.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hi Experts,

Please find the attached patch.

It will allow you to remove the link between sale order/purchase order and its picking, which in turn lets you cancel the SO/PO.

Moreover, the act_window link of 'Packing' from Purchase order has been corrected too.

Please post your suggestions.

I fear about cancellation of Procurement as the workflow does not seem efficient,but it is another issue yet relevant.

Thanks.

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Jay,

I agree with your patch. Thanks for fixing it !

Regards,

Joël

Revision history for this message
Richard (John) Nopkins@Servosoft (richard-nopkins) wrote :

hi,
my vote goes to jay and joel.
thanks both.

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Just a quick note: the proposed patch for 5.0 sounds low-risk enough but I think it's not quite user-friendly ;-)
Could we consider modifying also the message that prevent the cancel of the SO to mention that it's also possible to manually disconnect the picking using this technique?

And as for 6.0, as Joel explains it's quite difficult to find a clean solution w.r.t. the workflow, so I guess porting the same solution as for 5.0 is not that bad.

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hello,

I applied the patch and I confirm that the scenario is working.

Regards,

Guewen Baconnier

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hi Experts,

Corrections have taken place by revision 2817 <email address hidden>.

Thanks for your feedbacks and time.

Revision history for this message
Harry (OpenERP) (hmo-tinyerp) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Hello Expert,
We can not allow "Cancel" Picking after Done it. If We need cancel picking, We can use "Return Picking Wizard" to reverse entry.

Thanks

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi,

I've just tested the cancellation of PO and SO with invoice or without once the packing is done. Everything is just perfect :

1. Confirm SO or PO
2. Confirm the packing
3. Remove the link of packing on related SO / PO
4. Use the return packing wizard to inverse the stock move in order to have correct stock quantities
5. Cancel & recreate the SO / PO, so it regenerate the packing !

Thanks for the fix,

Regards,

Joël

Revision history for this message
Ana Juaristi Olalde (ajuaristio) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Also working for me.

Thank you very much!

Ana

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Thanks Joël and Ana,

Thanks a lot for Feedbacks.

We would like to close this issue for trunk as well.

Should we go for the similar solution for 6.0 too?

No more complex solution is supposed to be applied as time doesn't permit it currently for 6.0.

Thanks.

Revision history for this message
Raphaël Valyi - http://www.akretion.com (rvalyi) wrote :

Hello Jay,

Thanks for that V5 fix.
I think the same is required in v6 indeed. Notice however that currently on v6, the "return the packing" wizard doesn't work more than once because of that important osv.memory bug https://bugs.launchpad.net/openobject-server/+bug/620714

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Jay,

I think that if we have no more time, this solution is good enough to allow people working correctly. I vote to apply the same solution for V6.0.

I just want to report that we also have the same kind of trouble on PO. We aren't allowed to delete or even cancel a "Done" PO (even if it has not generated a picking). This is also a problem cause we should have a way to deal with that too.

As we solve this for SO, I think we should apply the same logic on PO. We should be able to cancel a PO with no linked picking. This is not the case yet, and I cannot delete it as well cause of the new check in unlink function (state != draft, cancel).

Do you can include this for this fix/bugfix or do you want me to open a new one ?

Regards,

Joël

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote : Re: Regression on sales flow, no way to cancel SO anymore

Hello Experts,

Your comments have been counted.

@ Raphaël,Indeed osv.memory bug will be on the list of fixes today.

@ Joël, Sorry I did not get you. The fix already contains the change for PO. Should we allow the deletion of a done PO/sO?

Moreover,we would like to confirm the fix for https://bugs.launchpad.net/openobject-addons/+bug/613063 and get more feedback.

Keep posting.

Thanks.

summary: - Regression on sales flow, no way to cancel SO anymore
+ SO/PO should be allowed to be cancelled by un-linking the concerned
+ packing!
Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hi,

Appropriate fix has been applied to trunk by revision 4779 <email address hidden>.

Thank you everyone for your participation.

We would like to ask you to share your views here : https://bugs.launchpad.net/openobject-addons/+bug/613063

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Jay,

You are right we can also delete the link on PO from picking. But as for SO, we need a way to delete or cancel the PO as well. Imagine someone made a mistake on a PO and confirm it :

- If the PO generated a picking list, we should be able to delete the link to PO and return it through "return packing" wizard so stock quantities are ok (this is ok). Then we should be able to delete or cancel the PO (this is impossible)

- If the PO has not generated a picking list (for example, you only write the description on it, but with no associated product), then you should be able to delete or cancel it (this is not possible).

Actually, if the PO is Done, there is no way to delete or cancel it and this is not really good for the end user. I suggest that a PO without linked picking can be deleted (or canceled) according to the user right of course.

Cancel will be my best choice (and a set to draft button as well) but I understand it may be could not be included into stable release (go for it on v6). Otherwise, I think we should replace the state != Done on unlink function by a check on "is there any linked picking".

Hope it's more clear now.

Regards,

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Joel,

I prefer that you go for another bug report,which will help other users to focus on a particular problem.

I don't say I agree/disagree, we would opt for the best optimal and concrete solution which is globally accepted.

There is another bug which says the similar issue of REVERTING DONE entry.https://bugs.launchpad.net/openobject-addons/+bug/528320

Requesting again,We would like to ask you to share your views here : https://bugs.launchpad.net/openobject-addons/+bug/613063.

Thanks.

Revision history for this message
rogerger (rogerger-py) wrote :

Hi guys,
   Thanks for pointing us to the right direction. However, I am a bit confused by the:

3. Remove the link of packing on related SO / PO

How do we actually do that in the GTK client? I have been trying for days without success.

Thanks.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Rogerer,

To perform the 3rd step, you should go to outgoing/incoming picking views.

The field Sale order/purchase order is now put as editable.Remove the reference from there.

Thanks.

Revision history for this message
rogerger (rogerger-py) wrote :

Jay,
   Thanks for providing the information. I have double-checked that the patch has been applied. However, when I go to outgoing products -> confirmed packing waiting availability, I got the screen as the attached image. The Original Reference is still showing gray and it can not be modified. The workflow process is Sale-Order -> Invoice from the Packing -> Packing.

I am wondering if I am missing something here. Thanks for the great help.

Regards,

Revision history for this message
rogerger (rogerger-py) wrote :

Please forgive me for the wrong attachment in the previous post. Please discard that.. The following is the correct one.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

Hello Rogerer,

The reference you point at is not the one which links sale order and the picking.

You are looking at the right screen, but the tab is not the targetted one.

You will need to go to the tab 'Other Info' and You will find the reference of sale order/purchase order. The reference is Many2one.

Hope this helps.

Thanks.

Revision history for this message
rogerger (rogerger-py) wrote : Re: [Bug 596862] Re: SO/PO should be allowed to be cancelled by un-linking the concerned packing!

Jay,
   Thanks for your helps. I finally found it in Other Info -> active Flag.
If I uncheck active checkbox, it will unlink SO with Packing Lists.

Thanks again

2010/9/3 Jay (OpenERP) <email address hidden>

> Hello Rogerer,
>
> The reference you point at is not the one which links sale order and the
> picking.
>
> You are looking at the right screen, but the tab is not the targetted
> one.
>
> You will need to go to the tab 'Other Info' and You will find the
> reference of sale order/purchase order. The reference is Many2one.
>
> Hope this helps.
>
> Thanks.
>
> --
> SO/PO should be allowed to be cancelled by un-linking the concerned
> packing!
> https://bugs.launchpad.net/bugs/596862
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in OpenObject Addons Modules: Fix Released
> Status in OpenObject Addons 5.0 series: Fix Released
> Status in OpenObject Addons trunk series: Fix Released
>
> Bug description:
> Hi,
>
>
> I just realized that with the new check on the last version it's just
> impossible to cancel a SO when his picking has already been confirmed !!!
>
> I mean, this should not appear in a normal flow, I agree, but what to do
> when you're facing this !??
>
> To reproduce :
>
> 1. Create a SO with 1 line (no matter the configuration)
> 2. Confirm it, go to the packing and confirmed it (force if necessary)
> 3. Go back to the SO, try to cancel => It says you must cancel the packing
> first !
> => Normal
> 4. Goto to the packing, you cannot cancel it, there is no button ! The
> workflow doesn't allow to cancel the "done" packing !
> => Can be normal...
> 5. Ok, so now you try to Delete this "done" packing in order to cancel your
> SO and it's not possible anymore !!! Says you cannot delete a done packing
>
> So, you cannot cancel, you cannot delete the packing... But you need one of
> those solutions to delete your SO !!
>
> We do need something here to be able to cancel the SO, whatever it is.
>
> I'll suggest to enable the workflow transition from Done to Cancel state
> into packing. Doing this, we'll be able to ensure who's doing that through
> "role" security.
>
> Thanks,
>
>
> Joël
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openobject-addons/+bug/596862/+subscribe
>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.