Comment 4 for bug 712614

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

@Scott, good point, logname is not passed through with this patch, so I think its not really acceptible yet, so I'll unsubscribe sponsors.

@Adrian, the patch is *almost* ready, but not quite. Once the following changes are done, I'd be happy to send it upstream. Instructions for doing so yourself are here:

http://git.kernel.org/?p=utils/util-linux/util-linux.git;a=blob_plain;f=README.devel;hb=master

Here are the changes that need to be made:

a) you need to append "--",logname as the final arguments to login, or explain why you feel thats not necessary anymore.
b) the code is a bit off from the formatting standards, which are here:
  http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=Documentation/CodingStyle
  (ignore bits about spaces vs. tabs. util-linux seems to be indented with spaces. Everything else applies).
  Specifically
    - comments must be /* .. */
    - put a space after commas in function arguments.
c) make the patch from the root of the source tree, not from inside term-utils.
d) Just FYI, in newer versions, agetty.c has moved from login-utils to term-utils.

@Adrian, please do these things and then re-subscribe ubuntu-sponsors

Marking the bug as Confirmed, importance Wishlist. I can see this as quite useful for a secured physical serial console where you just want the user logged in as soon as they plug in to it.