Comment 2 for bug 712614

Revision history for this message
Scott Moser (smoser) wrote :

Could you propose this patch upstream ? It seems like something that is generally useful and would be accepted.

I have two comments on the patch, though
1.) you did not use wordfree on the wordexp_t, i'm guessing just because this is a short lived program, but just for cleanliness, I'd think it would be good to add it.
2.) I could be missing something, but it looks to me like you will change the behavior of existing code.
   Previously, the command run would be:
     options.login -- logname
  And now, it appears to me that that would be just:
    options.login
  Shouldn't you append the '--' 'logname' somehow ?