| 2023-04-05 13:23:15 |
Dominic Evans |
bug |
|
|
added bug |
| 2023-04-05 13:27:47 |
Dominic Evans |
tags |
|
patch |
|
| 2023-04-05 13:47:31 |
Dominic Evans |
attachment added |
|
2015355.patch https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/2015355/+attachment/5661201/+files/2015355.patch |
|
| 2023-04-05 16:28:02 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2023-04-13 18:19:02 |
Brian Murray |
tags |
patch |
patch rls-ff-incoming |
|
| 2023-04-13 19:06:45 |
Pedro Principeza |
bug |
|
|
added subscriber Pedro Principeza |
| 2023-05-11 15:31:11 |
Steve Langasek |
tags |
patch rls-ff-incoming |
patch |
|
| 2023-05-11 15:31:22 |
Steve Langasek |
nominated for series |
|
Ubuntu Focal |
|
| 2023-05-11 15:31:22 |
Steve Langasek |
bug task added |
|
util-linux (Ubuntu Focal) |
|
| 2023-05-11 15:32:34 |
Steve Langasek |
tags |
patch |
fr-4345 patch |
|
| 2023-05-11 15:32:35 |
Steve Langasek |
tags |
fr-4345 patch |
foundations-todo patch |
|
| 2023-05-11 15:45:18 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Foundations Bugs |
| 2023-05-11 17:58:34 |
Joao Andre Simioni |
bug |
|
|
added subscriber Joao Andre Simioni |
| 2023-05-30 17:41:10 |
Nick Rosbrook |
util-linux (Ubuntu): status |
New |
Fix Released |
|
| 2023-05-30 17:43:15 |
Nick Rosbrook |
description |
There are three patches in util-linux upstream that were released in util-linux 2.37 and prevent false detection of the atari partition table with blkid and wipefs. We see this mostly on LUKS devices initialised via luksFormat reporting there is an atari partition table on the device when it is empty. This causes issues in various places, but one key example for us is in kubernetes where mount-utils will refuse to format the device (https://github.com/kubernetes/mount-utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441)
RedHat backported these fixes to RHEL 8 under https://bugzilla.redhat.com/show_bug.cgi?id=2060030 and it would be helpful if Ubuntu also backported them to Ubuntu 20.04 which is still running util-linux 2.34
The request is to backport patches based on the https://github.com/util-linux/util-linux/issues/1159 upstream report.
Upstream commits to cherry-pick the changes to libblkid/src/partitions/atari.c from:
2cc76d50d7a14bef8e7b07fab11b26c9e49d36a2
282ceadc3a72fc07dd0388b8880fd751490bb87f
c70b4f2a5b99876d230b8f4f413c3bb3ee6647f1
# lsb_release -a
Distributor ID: Ubuntu
Description: Ubuntu 20.04.6 LTS
Release: 20.04
Codename: focal
# blkid -V
blkid from util-linux 2.34 (libblkid 2.34.0, 14-Jun-2019)
# blkid -p -s TYPE -s PTTYPE -o export /dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
DEVNAME=dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
PTTYPE=atari
# lsblk
...
sdc crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64
`-3600a09803830474a735d4c63744c4a56 crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64
`-pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted |
[Impact]
The partition detection logic in libblkid1 can falsely report the presence of an atari partition. One place where this has a practical impact is in kubernetes where mount-utils will refuse to format the device (https://github.com/kubernetes/mount-utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441).
[Test Plan]
* Create a new qcow2 disk image:
$ qemu-img create -f qcow2 test.img 20G
* Boot a focal ISO with QEMU/KVM as if installing to test.img:
$ qemu-system-x86_64 -enable-kvm -m 4096 -name test -drive file=test.img,format=qcow2 -net nic,model=virtio -net user,hostfwd=tcp::1022-:22 -vga virtio -cdrom ubuntu-20.04.6-desktop-amd64.iso
* Using the live environment, format the empty disk. These particular commands were given as a reproducer on the upstream bug report (https://github.com/util-linux/util-linux/issues/1116).
$ parted -s /dev/sda -- mklabel msdos
$ parted -s /dev/sda -- mkpart primary 0% 10% mkpart primary 10% 30%
* Run wipefs on /dev/sda to list partitions. On an affected machine, an atari partition will be listed. On a fixed machine, the incorrect atari listing will be gone.
$ wipefs /dev/sda
DEVICE OFFSET TYPE UUID LABEL
sda 0x1fe dos
sda 0x1d2 atari
[Where problems could occur]
These patches specifically address the atari prober logic in libblkid. Therefore, if we saw regressions it would be related to detecting atari partitions with libblkid. This would potentially impact tools such as wipefs and blkid, or any other tool that uses libblkid1 for this purpose.
[Original Description]
There are three patches in util-linux upstream that were released in util-linux 2.37 and prevent false detection of the atari partition table with blkid and wipefs. We see this mostly on LUKS devices initialised via luksFormat reporting there is an atari partition table on the device when it is empty. This causes issues in various places, but one key example for us is in kubernetes where mount-utils will refuse to format the device (https://github.com/kubernetes/mount-utils/blob/732a08ae47571516020ef99c303c70c1fa5b3e6c/mount_linux.go#L437-L441)
RedHat backported these fixes to RHEL 8 under https://bugzilla.redhat.com/show_bug.cgi?id=2060030 and it would be helpful if Ubuntu also backported them to Ubuntu 20.04 which is still running util-linux 2.34
The request is to backport patches based on the https://github.com/util-linux/util-linux/issues/1159 upstream report.
Upstream commits to cherry-pick the changes to libblkid/src/partitions/atari.c from:
2cc76d50d7a14bef8e7b07fab11b26c9e49d36a2
282ceadc3a72fc07dd0388b8880fd751490bb87f
c70b4f2a5b99876d230b8f4f413c3bb3ee6647f1
# lsb_release -a
Distributor ID: Ubuntu
Description: Ubuntu 20.04.6 LTS
Release: 20.04
Codename: focal
# blkid -V
blkid from util-linux 2.34 (libblkid 2.34.0, 14-Jun-2019)
# blkid -p -s TYPE -s PTTYPE -o export /dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
DEVNAME=dev/mapper/pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted
PTTYPE=atari
# lsblk
...
sdc crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64
`-3600a09803830474a735d4c63744c4a56 crypto_LUKS a79d2982-74f2-44c7-bb29-460768ebfe64
`-pvc-7b331195-cd5a-4ab6-8fdc-552af4b9139d_encrypted |
|
| 2023-05-30 17:43:26 |
Nick Rosbrook |
util-linux (Ubuntu Focal): status |
New |
In Progress |
|
| 2023-05-30 17:43:31 |
Nick Rosbrook |
util-linux (Ubuntu Focal): importance |
Undecided |
Low |
|
| 2023-05-30 17:43:34 |
Nick Rosbrook |
util-linux (Ubuntu Focal): assignee |
|
Nick Rosbrook (enr0n) |
|
| 2023-06-01 16:06:15 |
Ubuntu Archive Robot |
bug |
|
|
added subscriber Steve Langasek |
| 2023-06-02 15:10:14 |
Nick Rosbrook |
merge proposal linked |
|
https://code.launchpad.net/~enr0n/ubuntu/+source/util-linux/+git/util-linux/+merge/443898 |
|
| 2023-06-02 19:34:05 |
Steve Langasek |
util-linux (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2023-06-02 19:34:06 |
Steve Langasek |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-06-02 19:34:11 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2023-06-06 14:39:28 |
Nick Rosbrook |
tags |
foundations-todo patch |
foundations-todo patch verification-done-focal |
|
| 2023-06-12 12:06:55 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2023-06-12 12:06:53 |
Launchpad Janitor |
util-linux (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2023-10-23 15:08:41 |
Benjamin Drung |
tags |
foundations-todo patch verification-done-focal |
patch verification-done-focal |
|
