Please backport patches for false atari partition detection to Ubuntu 20.04
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
util-linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Low
|
Nick Rosbrook |
Bug Description
[Impact]
The partition detection logic in libblkid1 can falsely report the presence of an atari partition. One place where this has a practical impact is in kubernetes where mount-utils will refuse to format the device (https:/
[Test Plan]
* Create a new qcow2 disk image:
$ qemu-img create -f qcow2 test.img 20G
* Boot a focal ISO with QEMU/KVM as if installing to test.img:
$ qemu-system-x86_64 -enable-kvm -m 4096 -name test -drive file=test.
* Using the live environment, format the empty disk. These particular commands were given as a reproducer on the upstream bug report (https:/
$ parted -s /dev/sda -- mklabel msdos
$ parted -s /dev/sda -- mkpart primary 0% 10% mkpart primary 10% 30%
* Run wipefs on /dev/sda to list partitions. On an affected machine, an atari partition will be listed. On a fixed machine, the incorrect atari listing will be gone.
$ wipefs /dev/sda
DEVICE OFFSET TYPE UUID LABEL
sda 0x1fe dos
sda 0x1d2 atari
[Where problems could occur]
These patches specifically address the atari prober logic in libblkid. Therefore, if we saw regressions it would be related to detecting atari partitions with libblkid. This would potentially impact tools such as wipefs and blkid, or any other tool that uses libblkid1 for this purpose.
[Original Description]
There are three patches in util-linux upstream that were released in util-linux 2.37 and prevent false detection of the atari partition table with blkid and wipefs. We see this mostly on LUKS devices initialised via luksFormat reporting there is an atari partition table on the device when it is empty. This causes issues in various places, but one key example for us is in kubernetes where mount-utils will refuse to format the device (https:/
RedHat backported these fixes to RHEL 8 under https:/
The request is to backport patches based on the https:/
Upstream commits to cherry-pick the changes to libblkid/
2cc76d50d7a14be
282ceadc3a72fc0
c70b4f2a5b99876
# lsb_release -a
Distributor ID: Ubuntu
Description: Ubuntu 20.04.6 LTS
Release: 20.04
Codename: focal
# blkid -V
blkid from util-linux 2.34 (libblkid 2.34.0, 14-Jun-2019)
# blkid -p -s TYPE -s PTTYPE -o export /dev/mapper/
DEVNAME=
PTTYPE=atari
# lsblk
...
sdc crypto_LUKS a79d2982-
`-3600a09803830
`-pvc-
Related branches
- Steve Langasek (community): Approve
-
Diff: 376 lines (+323/-0)7 files modifieddebian/changelog (+14/-0)
debian/patches/libblkid-fix-Atari-prober-logic.patch (+47/-0)
debian/patches/libblkid-make-Atari-more-robust.patch (+120/-0)
debian/patches/series (+4/-0)
debian/patches/tests-update-atari-blkid-tests.patch (+83/-0)
debian/patches/tests-update-atari-partx-tests.patch (+53/-0)
debian/source/include-binaries (+2/-0)
tags: | added: patch |
tags: | added: rls-ff-incoming |
tags: | removed: rls-ff-incoming |
tags: | added: fr-4345 |
tags: |
added: foundations-todo removed: fr-4345 |
tags: | removed: foundations-todo |
git format-patch --stdout --no-signoff tags/v2.34... -- libblkid/ src/partitions/ atari.c