Comment 26 for bug 1676763

Revision history for this message
Jakub Vaněk (vanek-jakub4) wrote :

The two patches inside the debdiff fix these bugs:

 * First issue is that usb_modeswitch_dispatcher.c crashes when a device presented to it has no USB interface 0. This is caused by improper checking for a NULL pointer returned by a interface-lookup function. It is fixed by adding a null-check and gracefully exiting the program if there is no interface 0. This should be consistent with how the upstream Tcl script handled this.

 * Second issue is that usb_modeswitch_dispatcher.c writes an unexpected literal "(null)" string to usb_modeswitch command line. This suprisingly does not cause any malfunction, because the argument is ignored by usb_modeswitch. The problem is caused by assignment of NULL to a variable where strdup("") should have been used instead. The problem is fixed by using strdup, which is consistent with how this was handled in other cases as well.