Format action wipes all partitions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
usb-creator (Ubuntu) |
Fix Released
|
High
|
Dimitri John Ledkov | ||
Precise |
Won't Fix
|
High
|
Unassigned |
Bug Description
[rational]
"Erase Disk" action formats *all* partitions, instead of the selected partition only.
[test case]
1) Start usb creator
2) Select an individual partition
3) Click on erase/format
4) Check that the other partitions haven't been touched
[regression potential]
The fix has been in quantal for a while and peer reviewed before that, this fix leads to quite a bit of code being moved around but still limited to the erase/formatting code.
As it's code doing drive formatting, regressions can be pretty nasty with potential dataloss, though I can't find any indication that it'd affect another block device than that selected and so the worst case scenario I can see is basically what we currently have in precise (wiping a partition wipes the whole drive).
Related branches
- Evan: Pending requested
- usb-creator hackers: Pending requested
-
Diff: 57 lines (+20/-13)2 files modifiedbin/usb-creator-helper (+20/-9)
usbcreator/backends/udisks/backend.py (+0/-4)
- Dimitri John Ledkov: Needs Information
-
Diff: 149 lines (+83/-4)5 files modifiedbin/usb-creator-helper (+1/-1)
debian/changelog (+5/-1)
debian/copyright (+5/-0)
usbcreator/backends/devicekit/backend.py (+1/-1)
usbcreator/frontends/gtk/frontend.py (+71/-1)
Changed in usb-creator (Ubuntu): | |
importance: | Undecided → High |
summary: |
- Wrong behaviour on format action + Format action wipes all paritions |
summary: |
- Format action wipes all paritions + Format action wipes all partitions |
tags: | added: karmic lucid patch |
tags: | added: css-sponsored-p |
tags: | added: rls-mgr-p-tracking |
Changed in usb-creator (Ubuntu): | |
assignee: | Roderick B. Greening (roderick-greening) → nobody |
status: | In Progress → Triaged |
assignee: | nobody → Canonical Foundations Team (canonical-foundations) |
milestone: | later → none |
description: | updated |
Changed in usb-creator (Ubuntu): | |
status: | Triaged → Fix Committed |
Changed in usb-creator (Ubuntu Precise): | |
assignee: | Dmitrijs Ledkovs (dmitrij.ledkov) → Stéphane Graber (stgraber) |
Changed in usb-creator (Ubuntu Precise): | |
status: | Triaged → In Progress |
description: | updated |
Changed in usb-creator (Ubuntu Precise): | |
milestone: | ubuntu-12.04.1 → ubuntu-12.04.2 |
Changed in usb-creator (Ubuntu Precise): | |
milestone: | ubuntu-12.04.2 → ubuntu-12.04.3 |
Changed in usb-creator (Ubuntu Precise): | |
assignee: | Stéphane Graber (stgraber) → nobody |
Just to be clear, are you saying that you told it to format one of the two partitions, and it then formated the entire device instead?