Comment 7 for bug 1817595

Revision history for this message
Julian Andres Klode (juliank) wrote :

Some review:

- debdiffs should be attached to the bug (not a gist)
- version number should follow https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging - e.g. 2ubuntu0.1, not 2ubuntu1

Unsubscribing ubuntu-sponsors. Once the issues have been addressed, please resubscribe.

Personally, I'd also keep the two commits in the one patch separate, makes it easier to check

I find the impact too long to read (but it's late). I don't fully comprehend the test cases - is the library header-only so that it needs a rebuild? Otherwise, what happens to existing binaries.