Comment 5 for bug 613231

Revision history for this message
James Hunt (jamesodhunt) wrote :

Hi Jouko. I agree with Clint. There are just a couple of points here:

- The patch no longer applies cleanly to the Ubuntu upstart package as upstart-job has changed a little.
- I'd personally prefer the variables to be called ECHO (rather than ECHO_NOTE) and ECHO_ERROR since its then a smaller change and less likely for errors to be introduced should someone change the file and inadvertently specify ECHO (as they used to).