Comment 26 for bug 1273462

Revision history for this message
Martin Pitt (pitti) wrote :

> No /etc/rc?.d/ links
Of course, but I thought the point here was that one could/would call /etc/init.d/mysql directly when doing manual admin operations.

The first part of the patch, which disables an init.d script when called through /etc/rc?.d/ is correct; if this happens (upstart job with rc?.d symlink) this indeed is racy and undefined, but at the same time it should happen very rarely. The description/test case should mention this part, and fixing this in Trusty is prudent.

My objection is with manual admin operations via calling /etc/init.d/foo; that seems to be the main focus of the patch -- the second part beginning with UPSTART_JOB=${0#/etc/init.d/}. That's what the description and test case talk about, and they don't talk about the above race on boot.

We really don't know about all Ubuntu packages and even less about third party packages. Calling "/etc/init.d/foo restart" may have worked for people some packages, and it is neither racy nor undefined; the patch is going to change that behaviour, and this is definitively not guaranteed to be regression proof.