Comment 21 for bug 525674

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Martin:
- I already removed one indirection with my former patch and love to remove one more.
  Simple code = good code - thanks for the good hint.
- I changed it slightly to use the existing variable so people recognize from which code
  it came and to avoid issues if one ever changes only one occurrence of that file name.
- changelog now contains the original intention (no stall to logins) and the avoidance of
  stalling apt-get update along with all other minor fixes that came up along the way

Michael:
- Good catch, I didn't realize that this were two totally independent pieces.

Scott:
- Another good catch, of a potentially rare but nasty to track down issue

Overall I want to thank all reviewers a lot - I highly appreciate this real community feeling.
The patch got way better and smaller at once.
Thank You!