Comment 18 for bug 525674

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Christian! Some remarks:

 - The introduction of data/get-motd-updates-available seems like an unnecessary indirection to me. Instead of checking the executability of that and run it, debian/90-updates-available could just directly do

  cat /var/lib/update-notifier/updates-available 2>/dev/null || true

or

  [ ! -r /var/lib/update-notifier/updates-available ] || cat /var/lib/update-notifier/updates-available

if you prefer that. This would be simpler IMHO.

 - changelog should point out that data/update-motd-updates-available now runs in the background, to avoid blocking "apt-get update" unnecessarily long.

These are just nitpicks, this looks fine by and large. Thanks for working on this!