[FFe] Add a indicator to show the status of Livepatch

Bug #1820259 reported by Andrea Azzarone on 2019-03-15
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-notifier (Ubuntu)
Medium
Unassigned
Bionic
Undecided
Unassigned

Bug Description

* Impact
The livepatch graphical interfaces are currently limited in bionic, there is no easy way to know the current status and the details of the changes applied. The new design improves the user experience and we want that to benefit the LTS users

* Test case
As per https://wiki.ubuntu.com/SoftwareUpdates#livepatch there should a indicator in the top bar to show the status of Livepatch.

* Regression potential
The indicator is new code/a new UI so the regression potential is low.

Note that the changes include some new strings. Those are translated in disco and
Launchpad shares translations between series so we should get those translations included in the next bionic langpacks export.

Related branches

Andrea Azzarone (azzar1) on 2019-03-15
Changed in update-notifier (Ubuntu):
assignee: nobody → Andrea Azzarone (azzar1)
importance: Undecided → Medium
Changed in update-notifier (Ubuntu):
status: New → In Progress
Łukasz Zemczak (sil2100) wrote :

Ok, in this case where the indicator will not appear at all on systems where Livepatch is not supported, this should be good to go. Approved.

Changed in update-notifier (Ubuntu):
status: In Progress → Triaged
Changed in update-notifier (Ubuntu):
status: Triaged → Fix Committed
Andrea Azzarone (azzar1) on 2019-04-05
tags: added: rls-bb-incoming
Sebastien Bacher (seb128) wrote :

It was fixed with https://bugs.launchpad.net/ubuntu/+source/update-notifier/3.192.15 (but the bug closing syntax was wrong so launchpad didn't automatically pick it up)

Changed in update-notifier (Ubuntu):
status: Fix Committed → Fix Released
description: updated
Łukasz Zemczak (sil2100) wrote :

I will accept this, but could you make sure that the documentation for bionic won't have to be modified anywhere? Can you send an e-mail to the ubuntu-doc team as a heads up? Thanks!

Changed in update-notifier (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic

Hello Andrea, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Will Cooke (willcooke) on 2019-05-07
tags: added: verification-failed-bionic
removed: verification-needed-bionic
tags: added: verification-failed verification-needed-bionic
removed: verification-failed-bionic verification-needed
Sebastien Bacher (seb128) wrote :

Why the verification-failed? It works here...

Will Cooke (willcooke) wrote :

I installed this and found a problem that should block releasing this:

Problem: The status icon shows even when the livepatch cli client is not installed.

Steps to reproduce:
  1) Install 18.04.2 and install the canonical-livepatch snap and enable livepatch with a key.
  2) Reboot
  3) Login and wait a few mins. Notice that the livepatch appindicator appears.
  4) snap remove the livepatch client and reboot.
  5) Log in and wait.
  6) Notice that the icon appears with the red "x".

What is expected:
If the Livepatch client is not installed, then the appindicator should not be shown.

From the Livepatch panel in software-properties-gtk it appears that something thinks that Livepatch is still available and *logged in*. i.e. the "Sign Out" button is active in the panel. My guess is that something keeping state does not handle livepatch being removed while there are still credentials held.

Will Cooke (willcooke) wrote :

It seems we are missing the "Show livepatch in the topbar" options in s-p-gtk as per:
https://wiki.ubuntu.com/SoftwareUpdates#livepatch

Also, I think that the design is to not show the icon if the livepatch client is not installed, but I will need to confirm that.

Will Cooke (willcooke) on 2019-05-08
Changed in update-notifier (Ubuntu):
assignee: Andrea Azzarone (azzar1) → nobody
Iain Lane (laney) wrote :

> Also, I think that the design is to not show the icon if the livepatch client is not installed, but I will need to confirm that.

That seems clearly right from the specification:

"The Livepatch switch should be both off and disabled, and the “Show Livepatch in the top bar” checkbox should be both unchecked and disabled, when:

[…]

Livepatch is not available for this system. […]"

and also this one is not implemented at the minute:

"[when] You are not signed in."

in other words you see the Livepatch indicator in a disabled state (with a red cross) when you've never turned on Livepatch, and that's wrong and looks bad. The impact of releasing this SRU would be to show a disabled indicator for everybody. Please see the attached screenshot.

So I think v-failed is right here.

tags: removed: rls-bb-incoming
Timo Aaltonen (tjaalton) wrote :

Hello Andrea, or anyone else affected,

Accepted update-notifier into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-notifier/3.192.1.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed
removed: verification-failed
Sebastien Bacher (seb128) wrote :

3.192.1.7 works fine here, the indicator shows with the current status and is now not displayed when the service is not in use (not changing the tag yet so Will/Iain have a chance to also give it a try before we release it)

Will Cooke (willcooke) wrote :

I've installed the latest version of update notifier.

$ apt-cache policy update-notifier
update-notifier:
  Installed: 3.192.1.7
  Candidate: 3.192.1.7
  Version table:
 *** 3.192.1.7 500
        500 http://gb.archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     3.192.1.5 500
        500 http://gb.archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     3.192 500
        500 http://gb.archive.ubuntu.com/ubuntu bionic/main amd64 Packages

Tests I have performed:

Started with a fresh install and enabled LivePatch via "Software and Updates"
Logged in with my U1
Result: LivePatch installed and enabled as expected.
OUTCOME: PASSED

Disabled LivePatch via "Software and Updates"
Checked it was disabled via cli
Result: The LivePatch icon disappears from the top bar as expected.
OUTCOME: PASSED

Renabled LivePatch via "Software and Updates"
Checked it was enabled via cli
Result: The LivePatch icon appears in the top bar again.
OUTCOME: PASSED

Disabled LivePatch and rebooted
Left logged in for 5 mins
Result: No icon was shown in the top bar
OUTCOME: PASSED

Marking verification-done.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-notifier - 3.192.1.7

---------------
update-notifier (3.192.1.7) bionic; urgency=medium

  * Backport some fixes for the previous changes, from Andrea Azzarone
  * Don't show the Livepatch indicator if livepatch is disabled.
  * Livepatch, Handle "applying" Livepatch state

update-notifier (3.192.1.6) bionic; urgency=medium

  * Add a Livepatch indicator in the system tray. (LP: #1820259)
  * Add a "Settings..." button to the Livepatch notification. (LP: #1823351)

 -- Sebastien Bacher <email address hidden> Fri, 24 May 2019 11:46:37 +0200

Changed in update-notifier (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for update-notifier has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers