Comment 6 for bug 87914

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for the patch. A easy way to test the patch is to run in the update-manager top level directory:
$ python -c 'from DistUpgrade.DistUpgradeView import FuzzyTimeToStr; FuzzyTimeToStr(3443)'
when the patch is applied. This leads to:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "DistUpgrade/DistUpgradeView.py", line 33
    if sec = 60*60*24:
           ^
SyntaxError: invalid syntax

After correcting the "=" to "==", I get:
$ python -c 'from DistUpgrade.DistUpgradeView import FuzzyTimeToStr; print FuzzyTimeToStr(3743)'
1 hours 2 minutes

So the patch fixes the cases where it is exactly one hour, but unfortunately not the case where its something between 1 hour and 2 hours.

If you could update the patch to cover those cases, that would be much appreciated.

Thanks,
 Michael