changelogs not listed for PPA packages

Bug #2068809 reported by Tormod Volden
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Low
Unassigned
Noble
Fix Released
Undecided
Unassigned

Bug Description

* Impact

When clicking on a package from a PPA in update-manager, the "Changes for XXX versions:" section will say:

"This update does not come from a source that supports changelogs."

Which seems a side effect of https://blog.launchpad.net/ppa/new-domain-names-for-ppas , the code filter on ppa.launchpad.net in the url where those are using ppa.launchpadcontent.net now

* Test case

- enable a ppa including an update for a package you have installed
- start update-manager and select that package
- check the long description at the bottom

it should display the changelog entry for the update

* Regression potential

The change is in the _extract_ppa_changelog_uri() function so a potential issue would impact updates coming from a ppa. Verify that those are correctly listed and include a valid description

-----------------------------------------------

The reason is that in _extract_ppa_changelog_uri() in /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py it checks only for ppa.launchpad.net but nowadays the URI will contain ppa.launchpadcontent.net instead.

With the below patch it will correctly display the changelogs:

--- /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py.orig 2024-04-16 11:56:33.000000000 +0200
+++ /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py 2024-06-08 20:33:51.462435498 +0200
@@ -338,7 +338,7 @@ class MyCache(DistUpgrade.DistUpgradeCac

         cdt = self[name].candidate
         for uri in cdt.uris:
- if urlsplit(uri).hostname != "ppa.launchpad.net":
+ if urlsplit(uri).hostname not in ("ppa.launchpad.net", "ppa.launchpadcontent.net"):
                 continue
             match = re.search("http.*/(.*)/(.*)/ubuntu/.*", uri)
             if match is not None:

Related branches

Revision history for this message
Tormod Volden (tormodvolden) wrote :
Changed in update-manager (Ubuntu):
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've uploaded the fix to Oracular.

There is another upload pending already in the Noble queue but the fix makes sense for a next upload.
Would you perhaps have some time to help with that and make the bug description SRU compliant (https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template)?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:24.10.4

---------------
update-manager (1:24.10.4) oracular; urgency=medium

  * Indent the recently changed line to avoid a linter E501 error

 -- Sebastien Bacher <email address hidden> Tue, 02 Jul 2024 14:30:15 +0200

Changed in update-manager (Ubuntu):
status: Fix Committed → Fix Released
description: updated
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Tormod, or anyone else affected,

Accepted update-manager into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:24.04.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Noble):
status: New → Fix Committed
tags: added: verification-needed verification-needed-noble
Revision history for this message
Nathan Teodosio (nteodosio) wrote :

In a 24.04 virtual machine I installed update-manager/1:24.04.8. I did

  apt-add-repository ppa:nteodosio/rebuilds

and started update-manager. It correctly showed the "Software Updater" in the list with the change log saying

--->
Technical description
[--snip--]

Changes for update-manager versions:
Installed version: 1:24.04.8
Available version: 5:74.04.2

Version 5:74.04.2:

  * foobar
<---

which is correct.

tags: added: verification-done verification-done-noble
removed: verification-needed verification-needed-noble
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:24.04.8

---------------
update-manager (1:24.04.8) noble; urgency=medium

  * Display changelogs also for PPA packages on ppa.launchpadcontent.net
    (lp: #2068809)

  [ Nathan Pratta Teodosio ]
  * Don't crash if the end-points of the Pro API fail (LP: #2064211).

 -- Sebastien Bacher <email address hidden> Mon, 08 Jul 2024 14:00:19 +0200

Changed in update-manager (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for update-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.