changelogs not listed for PPA packages

[Tormod Volden]

* Impact

When clicking on a package from a PPA in update-manager, the "Changes for XXX versions:" section will say:

"This update does not come from a source that supports changelogs."

Which seems a side effect of https://blog.launchpad.net/ppa/new-domain-names-for-ppas , the code filter on ppa.launchpad.net in the url where those are using ppa.launchpadcontent.net now

* Test case

- enable a ppa including an update for a package you have installed
- start update-manager and select that package
- check the long description at the bottom

it should display the changelog entry for the update

* Regression potential

The change is in the _extract_ppa_changelog_uri() function so a potential issue would impact updates coming from a ppa. Verify that those are correctly listed and include a valid description

-----------------------------------------------

The reason is that in _extract_ppa_changelog_uri() in /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py it checks only for ppa.launchpad.net but nowadays the URI will contain ppa.launchpadcontent.net instead.

With the below patch it will correctly display the changelogs:

--- /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py.orig 2024-04-16 11:56:33.000000000 +0200
+++ /usr/lib/python3/dist-packages/UpdateManager/Core/MyCache.py 2024-06-08 20:33:51.462435498 +0200
@@ -338,7 +338,7 @@ class MyCache(DistUpgrade.DistUpgradeCac

         cdt = self[name].candidate
         for uri in cdt.uris:
- if urlsplit(uri).hostname != "ppa.launchpad.net":
+ if urlsplit(uri).hostname not in ("ppa.launchpad.net", "ppa.launchpadcontent.net"):
                 continue
             match = re.search("http.*/(.*)/(.*)/ubuntu/.*", uri)
             if match is not None:

[Tormod Volden (tormodvolden)]

Merge request:
https://code.launchpad.net/~tormodvolden/update-manager/+git/update-manager/+merge/467152

[Sebastien Bacher (seb128)]

Thanks, I've uploaded the fix to Oracular.

There is another upload pending already in the Noble queue but the fix makes sense for a next upload.
Would you perhaps have some time to help with that and make the bug description SRU compliant (https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template)?

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:24.10.4

---------------
update-manager (1:24.10.4) oracular; urgency=medium

  * Indent the recently changed line to avoid a linter E501 error

 -- Sebastien Bacher <email address hidden> Tue, 02 Jul 2024 14:30:15 +0200