Preview widgets with state lose state when device rotation triggers a change in the number of preview widget columns
Bug #1595235 reported by
Albert Astals Cid
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Andrea Cimitan |
Bug Description
There's a few preview widgets that have state (i.e. when adding text to a new comment, or when doing an inline video preview), that state will get lost if changing the orientation of the device gets us more or less columns since old preview widgets will be deleted and new ones will be created.
We need either a way to reuse the preview widgets (probably hard) or a way to save/restore the information on destroy/creation.
Related branches
lp:~cimi/unity8/singleton-textarea
- Unity8 CI Bot: Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 198 lines (+102/-3)5 files modifiedqml/Dash/Previews/PreviewCommentInput.qml (+15/-0)
qml/Dash/Previews/PreviewRatingInput.qml (+27/-1)
tests/qmltests/Dash/Previews/tst_PreviewCommentInput.qml (+28/-0)
tests/qmltests/Dash/Previews/tst_PreviewInlineVideo.qml (+0/-2)
tests/qmltests/Dash/Previews/tst_PreviewRatingInput.qml (+32/-0)
lp:~cimi/unity8/preview-singleton
- Unity8 CI Bot: Needs Fixing (continuous-integration)
- Albert Astals Cid (community): Approve
-
Diff: 224 lines (+119/-0)7 files modifiedqml/Dash/GenericScopeView.qml (+4/-0)
qml/Dash/Previews/PreviewInlineVideo.qml (+47/-0)
qml/Dash/Previews/PreviewSingleton/PreviewSingleton.qml (+22/-0)
qml/Dash/Previews/PreviewSingleton/qmldir (+1/-0)
tests/mocks/QtMultimedia/mediaplayer.cpp (+1/-0)
tests/mocks/QtMultimedia/mediaplayer.h (+1/-0)
tests/qmltests/Dash/Previews/tst_PreviewInlineVideo.qml (+43/-0)
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Andrea Cimitan (cimi) |
Changed in unity8 (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
Status changed to 'Confirmed' because the bug affects multiple users.