Dash: Pull/Release to refresh should take into account background color
Bug #1596849 reported by
Albert Astals Cid
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
unity8 (Ubuntu) |
Fix Released
|
Medium
|
Albert Astals Cid |
Bug Description
Go to the BBC Sport scope.
Pull to refresh.
Realize that you can not see the text since it's basically black on black.
We have some other places on the Dash where we read the luminance of one color and choose another according to it, we should have something similar here and switch to a white-ish font color for the " Pull/Release to refresh" if the color of the background is too dark.
Related branches
lp:~aacid/unity8/pullToRefreshColorChangeWhenNeeded
- Unity8 CI Bot: Needs Fixing (continuous-integration)
- Michael Terry: Approve
-
Diff: 43 lines (+4/-0)3 files modifiedqml/Dash/DashPageHeader.qml (+2/-0)
qml/Dash/GenericScopeView.qml (+1/-0)
qml/Dash/PullToRefreshScopeStyle.qml (+1/-0)
Changed in unity8 (Ubuntu): | |
importance: | Undecided → Medium |
assignee: | nobody → Josh Arenson (josharenson) |
Changed in unity8 (Ubuntu): | |
assignee: | Josh Arenson (josharenson) → Albert Astals Cid (aacid) |
status: | New → In Progress |
To post a comment you must log in.
This bug was fixed in the package unity8 - 8.14+16. 10.20160922- 0ubuntu1
--------------- 10.20160922- 0ubuntu1) yakkety; urgency=medium
unity8 (8.14+16.
[ Albert Astals Cid ] e.getCardCompon ent while the cardIconStyle change compare into tryCompareFunction est::test_ comboButton more stable tXChanged to work when the content changes very
* LVWPH: update clipItem height when list height changes (LP:
#1606935)
* Put the touchdown shape inside a loader
* No need for the touchdown in the card for the cardtool
* Add bottom gradient to the Show Less floating button
* Remove artShapeSize from non cardtool cards
* LVWPH: Fix case in which header was shown incorrectly
* LVWPH: Fix items cut on top in the dash (or at least some instances
of it)
* Reduce calls to CardCreatorCach
component is being created (LP: #1615675)
* Dash::test_
* Make PreviewActionsT
* Adapt onShiftedConten
abruptly
* Make tryGenericScopeView show the scope correctly
* Make sure the spinner does not get too close to the title text (LP:
#1597392)
* Show "Pull to refresh" in white when overlaid in low luminance
colors (LP: #1596849)
* Make test_Shell non ultra slow again (LP: #1597366)
* Improve findChild calls inside tryCompareFunction.
[ Andrea Cimitan ] dash_move_ current
* override some Qt Components definitions so we can have sane default
values for flick speeds
* Elide the label text inside recent searches panel (LP: #1611796)
* Add a PreviewSingleton module to store some data for previews (LP:
#1595235)
* Use PreviewSingleton for PreviewRatingInput and PreviewCommentInput
(LP: #1595235)
* rework GenericScopeView PullToRefresh test
* use mouseFlick instead touchFlick for manage_
* add a couple of waiting tricks for a flaky dash test
[ Daniel d'Andrada ]
* Set progress bar indeterminate when processing signal received. (LP:
#1249349)
* Implement cursor confinement (LP: #1590099)
[ Josh Arenson ]
* Add a frontend to the sessions model and enable a session chooser in
the greeter.
[ Lukáš Tinkl ]
* Implement edge maximizing (aka window snapping) (LP: #1602628)
* On the PC platform (as opposed to running on $devices), use the
"mute" action instead of silent mode
* Respect Fitt's law wrt the window control buttons in panel (LP:
#1611959)
* Fix 2 failing color-related tests
[ Marco Trevisan (Treviño) ]
* Indicators, mocks: add fake indicators menuitem to populate mocks
with different menu types
* IndicatorsClient: use PageHeader and ListItemLayout's
[ Michael Terry ]
* Support launching apps inside a unity8 session from the greeter and
support emergency dialing inside the greeter.
* Fix tryShell to actually show appropriate backgrounds for each mock
user.
* Add an indicator to the greeter when a user is logged in (only shown
if we have more than one user)
* Hide the greeter OSK if indicators are open and don't show the edge
tutorial during an emergency call.
* Switch from lockscreen PIN pad to a passcode entry box that uses the
OSK.
* Use the default system wallpaper instead of our custom one.
* Update look of infographi...