Comment 6 for bug 1480654

Revision history for this message
Daniel van Vugt (vanvugt) wrote : Re: Input focus delay after switching app back into focus since OTA5 (Mir 0.14)

Bisected. Actually, trisected. There were three separate regressions to input and focus (one of them fixed), and we're now seeing the cumulative effect of the other two.

First regression: r2590 slightly broke focus changing such that the focus change is sometimes withheld and delayed until your touch gesture in the old window finishes. It doesn't matter how long your gesture takes, since r2590 Mir would delay the focus switch till the gesture is completed (fingers raised).

Second regression: r2652 broke touch input completely. It did not work at all until fixed in r2656 (LP: #1464174).

Third regression: Some combination of r2652-r2656 created the behaviour we see today. That is the focus change takes effect immediately but touch events are ignored for about the first second after the focus change. I can't tell which revision caused the exact problem because the second regression remained unresolved during this time so there was no working touch support to test with.

The exact offending revisions to investigate are:

------------------------------------------------------------
revno: 2590 [merge]
author: Robert Carr <email address hidden>, <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Thu 2015-05-21 02:17:18 +0000
message:
  Unify MirMotionTooltype and MirTouchTooltype.

  Approved by PS Jenkins bot, Andreas Pokorny, Alberto Aguirre, Kevin DuBois, Al
exandros Frantzis.
------------------------------------------------------------
------------------------------------------------------------
revno: 2652 [merge]
author: Robert Carr <email address hidden>, <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Wed 2015-06-10 23:37:28 +0000
message:
  Replace android input dispatcher with a slimmed down rewrite suitable to Mir's
 requirements. Fixes: https://bugs.launchpad.net/bugs/1419048.

  Approved by PS Jenkins bot, Alexandros Frantzis, Andreas Pokorny, Chris Halse
Rogers.
------------------------------------------------------------
------------------------------------------------------------
revno: 2656 [merge]
author: <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Fri 2015-06-12 05:34:31 +0000
message:
  Fix key repeat dispatcher (touch events not working at all)
  (LP: #1464174). Fixes: https://bugs.launchpad.net/bugs/1464174.

  Approved by Daniel van Vugt, Alberto Aguirre, PS Jenkins bot.
------------------------------------------------------------

Ironically, Robert has departed the company as of 3 days ago :/