Comment 4 for bug 1467740

Revision history for this message
Albert Astals Cid (aacid) wrote :

> Well, consider the cost of scaling down from a full-size photo to a thumbnail. It takes a quarter of a second on a Nexus 4.
Yes, that should be done as few times as possible.

> Surely, it's not too much to ask the caller what size thumbnail it wants?
It actually is, i have no idea of the image i want unless you tell me the aspect ratio and since i can't know the aspect ratio i need the full image.

> The meaning of (-1, -1) is "I don't know what I need, just give me something.
You're making this up, the API documentation explicitly says "sourceSize can be cleared to the natural size of the image by setting sourceSize to undefined."

> The point here is that the thumbnailer has no business setting policy.
You say you have no business setting the policy but then go and set a policy that says "i'm not accepting undefined sizes even if the API says i should", please do not do that.