[TOPBLOCKER] [Dash] [design] Preview images display as black thumbnails
Bug #1333187 reported by
Michał Karnicki
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
The Savilerow project |
Fix Released
|
Critical
|
Unassigned | ||
Ubuntu UX |
Fix Released
|
High
|
Jouni Helminen | ||
unity8 (Ubuntu) |
Fix Released
|
Critical
|
Andrea Cimitan | ||
unity8 (Ubuntu RTM) |
Fix Released
|
Critical
|
Andrea Cimitan |
Bug Description
If the image is large, the Ubuntu shape rounded corners become very little, hardly noticable.
REQUESTED UX SOLUTION
Updated spec so images only zoomable once full screen.
For all other instances of ubuntu shape, SDK documentation should be used (see link from Jouni in comments)
Related branches
lp:~cimi/unity8/fix-1333187
Superseded
for merging
into
lp:unity8
- Albert Astals Cid (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 641 lines (+269/-162)7 files modifiedqml/Components/ZoomableImage.qml (+18/-15)
qml/Dash/Previews/PreviewImageGallery.qml (+14/-81)
qml/Dash/Previews/PreviewOverlay.qml (+115/-0)
qml/Dash/Previews/PreviewZoomableImage.qml (+38/-5)
tests/qmltests/Components/tst_ZoomableImage.qml (+21/-21)
tests/qmltests/Dash/Previews/tst_PreviewImageGallery.qml (+33/-32)
tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml (+30/-8)
lp:~unity-team/unity8/fix-1333187
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
- Michał Sawicz: Approve
- Albert Astals Cid: Pending requested
-
Diff: 1164 lines (+474/-470)9 files modifiedqml/Components/ZoomableImage.qml (+18/-15)
qml/Dash/Previews/PreviewImageGallery.qml (+14/-81)
qml/Dash/Previews/PreviewOverlay.qml (+115/-0)
qml/Dash/Previews/PreviewZoomableImage.qml (+38/-5)
tests/qmltests/Components/tst_ZoomableImage.qml (+21/-21)
tests/qmltests/Dash/Previews/tst_PreviewImageGallery.qml (+33/-32)
tests/qmltests/Dash/Previews/tst_PreviewZoomableImage.qml (+30/-8)
tests/qmltests/Panel/tst_IndicatorItem.qml (+205/-0)
tests/qmltests/Panel/tst_Panel.qml (+0/-308)
tags: | added: scope-dev |
Changed in ubuntu-ux: | |
assignee: | nobody → Mike Nagle (mikenagle) |
Changed in unity8 (Ubuntu): | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in ubuntu-ux: | |
assignee: | Mike Nagle (mikenagle) → nobody |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
status: | Fix Committed → Triaged |
summary: |
- Preview image rounded corners depend on image size + [sdk] Preview image rounded corners depend on image size |
Changed in ubuntu-ux: | |
importance: | Undecided → High |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → nobody |
assignee: | nobody → Jouni Helminen (jounihelminen) |
no longer affects: | unity8 |
summary: |
- [sdk] Preview image rounded corners depend on image size + Preview image rounded corners depend on image size |
summary: |
- Preview image rounded corners depend on image size + Preview images should not be scaled down but open fullscreen, just as + gallery does |
tags: | added: rtm14 |
Changed in unity8 (Ubuntu): | |
importance: | High → Critical |
Changed in savilerow: | |
importance: | Undecided → Critical |
summary: |
- Preview images should not be scaled down but open fullscreen, just as - gallery does + [Dash] Preview images should not be scaled down but open fullscreen, + just as gallery does |
summary: |
- [Dash] Preview images should not be scaled down but open fullscreen, - just as gallery does + [Dash] [design] Preview images should not be scaled down but open + fullscreen, just as gallery does |
summary: |
- [Dash] [design] Preview images should not be scaled down but open - fullscreen, just as gallery does + [Dash] [design] Preview images display as black thumbnails |
tags: | added: touch-2014-10-23 |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Committed |
Changed in unity8 (Ubuntu): | |
assignee: | Michał Sawicz (saviq) → Andrea Cimitan (cimi) |
Changed in unity8 (Ubuntu): | |
status: | Triaged → In Progress |
tags: |
added: touch-2014-10-30 removed: touch-2014-10-23 |
Changed in unity8 (Ubuntu RTM): | |
importance: | Undecided → Critical |
status: | New → In Progress |
assignee: | nobody → Andrea Cimitan (cimi) |
summary: |
- [Dash] [design] Preview images display as black thumbnails + [TOPBLOCKER] [Dash] [design] Preview images display as black thumbnails |
Changed in savilerow: | |
status: | New → Fix Released |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This happens for the zoomable image, because it gets scaled down to fit, while the corners are rounded at 1:1 scale...
Not sure how to solve this design-wise, we probably don't want to round the corners "after" scaling, maybe we simply need to always apply the same corner radius...