Comment 2 for bug 1229241

Revision history for this message
Paweł Stołowski (stolowski) wrote :

The attached fix for unity8 looks good and will most likely do what it's supposed to do, but I wonder if this is good strategy. What this change effectively means is: if scope is currently active (visible) while network becomes available, it will be refreshed; if it's not visible (but favorited), it will be marked "dirty" and refreshed when user swipes/selects it. To my understanding this will affect not only the after-boot scenario, but normal usage as well. What if network is flaky and goes offline/online a lot? We'll end up re-querying scopes more often than necessary, disregarding TTL of the results (currently visible results may still be "valid", but forcefully refreshed just because network gets available). Perhaps the shell should cooperate more closely with shell plugin with this, rather than forcing refresh?