Keyboard shortcut - don't show disabled shortcuts in keyboard shortcut help

Bug #926418 reported by Jean-Baptiste Lallement on 2012-02-03
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Medium
John Lea
unity (Ubuntu)
Medium
Andrea Azzarone
Precise
Medium
Unassigned

Bug Description

Reverting to Triarged because:

The shortcut disappeared but an empty whole is left.

The shortcuts should reflow if a previous item gets hidden. The groups headers should move as well and if there is a group without shortcut shown, the group header should also be hidden.

------------------------

SRU testcase

1. go to ccsm and disable a default shortcut from there e.g. super+s
2. press and hold super+s you will see something as in the attached screenshot
3. now install unity from precise-proposed
4. now there won't be any item that says 'Disabled'

It's useless to show disabled shortcut (shortcut without a shortcut sequence associated) in the keyboard shortcut help. Screenshot attached.

--------------

Desired solution:

- Disabled shortcuts should not be displayed

Jean-Baptiste Lallement (jibel) wrote :
Robert Roth (evfool) on 2012-02-04
Changed in unity (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
Omer Akram (om26er) on 2012-02-04
Changed in unity:
importance: Undecided → Low
status: New → Confirmed
John Lea (johnlea) on 2012-02-09
description: updated
tags: added: udp
Changed in ayatana-design:
assignee: nobody → John Lea (johnlea)
importance: Undecided → Medium
status: New → Triaged
Changed in unity:
milestone: none → backlog
Tim Penhey (thumper) on 2012-04-23
Changed in ayatana-design:
status: Triaged → Fix Committed
Changed in unity:
status: Confirmed → Triaged
Andrea Azzarone (azzar1) on 2012-04-23
Changed in unity:
milestone: backlog → 5.12.0
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity (Ubuntu):
assignee: nobody → Andrea Azzarone (andyrock)
Changed in unity:
status: Triaged → Fix Committed
Changed in unity (Ubuntu):
status: Confirmed → Fix Committed
Omer Akram (om26er) on 2012-04-26
description: updated
Didier Roche (didrocks) on 2012-04-27
Changed in unity:
status: Fix Committed → Fix Released

Hello Jean-Baptiste, or anyone else affected,

Accepted unity into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

tags: added: verification-needed
Download full text (6.0 KiB)

This bug was fixed in the package unity - 5.12-0ubuntu1

---------------
unity (5.12-0ubuntu1) precise-proposed; urgency=low

  * New upstream release.
    - Launcher, Alt-Tab - clicking on launcher item or selecting a app in Alt-
      Tab raises all app windows, not just most recently focused (LP: #959339)
    - [heap corruption?] compiz crashed with SIGSEGV in _int_malloc() from
      g_realloc() from ... from g_dbus_connection_send_message_with_reply()
      from g_object_unref() from unity::dash::HomeLens::Impl::~Impl() from
      unity::dash::HomeLens::~HomeLens() (LP: #931201)
    - compiz crashed with SIGSEGV in _int_malloc() from __libc_calloc() from
      XOpenDisplay() from nux::WindowThread::ThreadCtor() (LP: #947844)
    - Regression: Installing apps causes a terrible visual glitch-- have to
      restart X.org. (LP: #981168)
    - Window management - unity doesn't realise when applications bring their
      windows to the front (LP: #802816)
    - Dash - Clicking on the desktop dash border should do nothing, *NOT*
      close the dash (LP: #839472)
    - [FFe, UIFe] HUD - The HUD does not respect launcher icon size settings
      in autohide mode (LP: #921506)
    - compiz crashed with SIGSEGV in g_volume_get_mount() (LP: #918548)
    - multiple instances or double icons of application detected on bamfdaemon
      respawn (LP: #928912)
    - Panel is transparent when Dash is open; no blur no average BG color
      (LP: #965323)
    - Unity crashes with SIGSEGV when hitting debug DBus interface hard
      (LP: #979429)
    - compiz crashed with SIGSEGV in _int_malloc() from g_object_unref() from
      unity::dash::Model<unity::dash::FilterAdaptor>::~Model() (LP: #941750)
    - indicators menu are sometimes cut off at screen edge (LP: #883317)
    - the shortcut keys in workspace section of the shortcut overlay aren't
      translated (LP: #980828)
    - [regression] Dash keeps repainting unnecessarily (LP: #980924)
    - compiz crashed with SIGSEGV in nux::NTextureData::ClearData() from
      nux::NTextureData::~NTextureData() from nux::Texture2D::~Texture2D()
      (LP: #952378)
    - compiz crashed with SIGSEGV in g_object_unref() from
      unity::dash::Settings::~Settings() from
      unity::UnityScreen::~UnityScreen() (LP: #981764)
    - compiz crashed with SIGSEGV in unity::dash::ResultView::~ResultView()
      from unity::dash::ResultViewGrid::~ResultViewGrid() from
      nux::Object::Destroy() from nux::Object::UnReference() (LP: #942286)
    - compiz crashed with SIGSEGV in
      ends_with_iter_select<__gnu_cxx::__normal_iterator<char const*,
      std::basic_string<char> >, char const*, boost::algorithm::is_iequal>()
      from unity::ui::PointerBarrierWrapper::EmitCurrentData() (LP: #983268)
    - Chinese can't be shown completely in dash filter (LP: #984583)
    - [Unity 5.10] compiz crashed with SIGSEGV in
      unity::hud::HudIconTextureSource::ColorForIcon() from
      unity::hud::Icon::Icon() from emit from unity::IconTexture::IconLoaded
      (LP: #983646)
    - [regression] Close button does not close the dash/HUD (LP: #986264)
    - compiz crashed with SIGSEGV in g_volume_eject_with_operation_finish()
      fro...

Read more...

Changed in unity (Ubuntu):
status: Fix Committed → Fix Released
Changed in unity (Ubuntu Precise):
status: Fix Committed → Fix Released
Christian Giordano (nuthinking) wrote :

The shortcut disappeared but an empty whole is left.

The shortcuts should reflow if a previous item gets hidden. The groups headers should move as well and if there is a group without shortcut shown (not sure if this has been implemented), the group header should be hidden.

Changed in unity:
status: Fix Released → Triaged
John Lea (johnlea) wrote :

Reverting to triaged, seem nuthinking's comment #5

description: updated
Changed in unity (Ubuntu):
status: Fix Released → Triaged
Changed in unity (Ubuntu Precise):
status: Fix Released → Triaged
summary: - don't show disabled shortcut in keyboard shortcut help
+ Keyboard shortcut - don't show disabled shortcuts in keyboard shortcut
+ help
John Lea (johnlea) on 2012-10-15
Changed in unity:
importance: Low → Medium
Changed in unity (Ubuntu):
importance: Low → Medium
Changed in unity (Ubuntu Precise):
importance: Low → Medium
Mathew Hodson (mathew-hodson) wrote :

The package in precise-proposed was released, so removing the verify tag.

tags: removed: verification-needed
Mathew Hodson (mathew-hodson) wrote :

This is fixed in Trusty from my testing.

Changed in unity (Ubuntu):
status: Triaged → Fix Released
Andrea Azzarone (azzar1) on 2017-10-13
no longer affects: unity
Changed in unity (Ubuntu):
assignee: Andrea Azzarone (azzar1) → nobody
assignee: nobody → Andrea Azzarone (azzar1)
Changed in unity (Ubuntu Precise):
assignee: Andrea Azzarone (azzar1) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers