Activity log for bug #852984

Date Who What changed Old value New value Message
2011-09-18 04:38:37 Wildjiji bug added bug
2011-09-18 04:38:37 Wildjiji attachment added dash-button-bug.jpg https://bugs.launchpad.net/bugs/852984/+attachment/2420335/+files/dash-button-bug.jpg
2011-09-18 10:26:41 Omer Akram unity (Ubuntu): importance Undecided Low
2011-09-18 10:26:43 Omer Akram unity (Ubuntu): status New Confirmed
2011-09-18 10:26:46 Omer Akram bug task added unity
2011-09-18 10:26:52 Omer Akram unity: importance Undecided Low
2011-09-18 10:26:54 Omer Akram unity: status New Confirmed
2011-09-18 10:30:03 Omer Akram description When the dash menu is opened, the maximize / unmaximize button does not match the actual window size. I think that initial image of the button is wrong. [How To Reproduce] 1. Open Dash menu 2. Click maximize / unmaximize button (repeat several times) Please see attached screen shot file. [Actual Result] Button image will be changed by pressing as following: unmaximize -> unmaximize -> maximize -> unmaximize ..... [Expected Result] Button image should be changed by pressing as following: maximize -> unmaximize -> maximize -> unmaximize ..... [How To Fix] I fix following patch. diff -ruN unity-4.16.0.org/plugins/unityshell/src/WindowButtons.cpp unity-4.16.0/plugins/unityshell/src/WindowButtons.cpp --- unity-4.16.0.org/plugins/unityshell/src/WindowButtons.cpp 2011-09-17 21:46:46.457858075 +0900 +++ unity-4.16.0/plugins/unityshell/src/WindowButtons.cpp 2011-09-18 00:10:23.331318340 +0900 @@ -59,6 +59,7 @@ _place_hidden_interest(0) { LoadImages(); + UpdateDashUnmaximize(); PanelStyle::GetDefault()->changed.connect(sigc::mem_fun(this, &WindowButton::LoadImages)); DashSettings::GetDefault()->changed.connect(sigc::mem_fun(this, &WindowButton::UpdateDashUnmaximize)); ProblemType: Bug DistroRelease: Ubuntu 11.10 Package: unity 4.16.0-0ubuntu1 [modified: usr/lib/compiz/libunityshell.so] ProcVersionSignature: Ubuntu 3.0.0-11.18-generic 3.0.4 Uname: Linux 3.0.0-11-generic i686 .tmp.unity.support.test.0: ApportVersion: 1.23-0ubuntu1 Architecture: i386 CompizPlugins: [core,bailer,detection,composite,opengl,imgjpeg,compiztoolbox,decor,place,imgpng,snap,vpswitch,regex,grid,move,session,gnomecompat,mousepoll,resize,animation,wall,animationaddon,workarounds,expo,ezoom,staticswitcher,fade,scale,unityshell] CompositorRunning: compiz CurrentDmesg: [ 933.179734] hrtimer: interrupt took 4970768 ns Date: Sun Sep 18 13:02:57 2011 DistUpgraded: Log time: 2011-06-26 00:04:58.605910 DistroCodename: oneiric DistroVariant: ubuntu DkmsStatus: vboxguest, 4.1.2, 3.0.0-11-generic, i686: installed GraphicsCard: InnoTek Systemberatung GmbH VirtualBox Graphics Adapter [80ee:beef] (prog-if 00 [VGA controller]) InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Alpha i386 (20110531.1) Lsusb: Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub Bus 002 Device 002: ID 80ee:0021 VirtualBox USB Tablet MachineType: innotek GmbH VirtualBox ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.0.0-11-generic root=UUID=7864bbca-c79e-4fb6-9189-4e10e752546c ro quiet splash vt.handoff=7 Renderer: Software SourcePackage: unity UpgradeStatus: Upgraded to oneiric on 2011-09-09 (8 days ago) dmi.bios.date: 12/01/2006 dmi.bios.vendor: innotek GmbH dmi.bios.version: VirtualBox dmi.modalias: dmi:bvninnotekGmbH:bvrVirtualBox:bd12/01/2006:svninnotekGmbH:pnVirtualBox:pvr1.2: dmi.product.name: VirtualBox dmi.product.version: 1.2 dmi.sys.vendor: innotek GmbH version.compiz: compiz 1:0.9.5.94+bzr2803-0ubuntu5 version.libdrm2: libdrm2 2.4.26-1ubuntu1 version.libgl1-mesa-dri: libgl1-mesa-dri 7.11-0ubuntu3 version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A version.libgl1-mesa-glx: libgl1-mesa-glx 7.11-0ubuntu3 version.xserver-xorg: xserver-xorg 1:7.6+7ubuntu7 version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.6.0-1ubuntu13 version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:6.14.99~git20110811.g93fc084-0ubuntu1 version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.15.901-1ubuntu2 version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:0.0.16+git20110411+8378443-1 1. make sure the dash is not maximzed 2. logout and login again or restart unity from terminal 3. open dash see the the maximize/unmaximize button. What happens its in the state as if dash is maximized What should happen when dash is not maximized the button in the panel should show the correct state =====Patch===== I fix following patch. diff -ruN unity-4.16.0.org/plugins/unityshell/src/WindowButtons.cpp unity-4.16.0/plugins/unityshell/src/WindowButtons.cpp --- unity-4.16.0.org/plugins/unityshell/src/WindowButtons.cpp 2011-09-17 21:46:46.457858075 +0900 +++ unity-4.16.0/plugins/unityshell/src/WindowButtons.cpp 2011-09-18 00:10:23.331318340 +0900 @@ -59,6 +59,7 @@        _place_hidden_interest(0)    {      LoadImages(); + UpdateDashUnmaximize();      PanelStyle::GetDefault()->changed.connect(sigc::mem_fun(this, &WindowButton::LoadImages));      DashSettings::GetDefault()->changed.connect(sigc::mem_fun(this, &WindowButton::UpdateDashUnmaximize)); ProblemType: Bug DistroRelease: Ubuntu 11.10 Package: unity 4.16.0-0ubuntu1 [modified: usr/lib/compiz/libunityshell.so] ProcVersionSignature: Ubuntu 3.0.0-11.18-generic 3.0.4 Uname: Linux 3.0.0-11-generic i686 .tmp.unity.support.test.0: ApportVersion: 1.23-0ubuntu1 Architecture: i386 CompizPlugins: [core,bailer,detection,composite,opengl,imgjpeg,compiztoolbox,decor,place,imgpng,snap,vpswitch,regex,grid,move,session,gnomecompat,mousepoll,resize,animation,wall,animationaddon,workarounds,expo,ezoom,staticswitcher,fade,scale,unityshell] CompositorRunning: compiz CurrentDmesg: [ 933.179734] hrtimer: interrupt took 4970768 ns Date: Sun Sep 18 13:02:57 2011 DistUpgraded: Log time: 2011-06-26 00:04:58.605910 DistroCodename: oneiric DistroVariant: ubuntu DkmsStatus: vboxguest, 4.1.2, 3.0.0-11-generic, i686: installed GraphicsCard: InnoTek Systemberatung GmbH VirtualBox Graphics Adapter [80ee:beef] (prog-if 00 [VGA controller]) InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Alpha i386 (20110531.1) Lsusb:  Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub  Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub  Bus 002 Device 002: ID 80ee:0021 VirtualBox USB Tablet MachineType: innotek GmbH VirtualBox ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.0.0-11-generic root=UUID=7864bbca-c79e-4fb6-9189-4e10e752546c ro quiet splash vt.handoff=7 Renderer: Software SourcePackage: unity UpgradeStatus: Upgraded to oneiric on 2011-09-09 (8 days ago) dmi.bios.date: 12/01/2006 dmi.bios.vendor: innotek GmbH dmi.bios.version: VirtualBox dmi.modalias: dmi:bvninnotekGmbH:bvrVirtualBox:bd12/01/2006:svninnotekGmbH:pnVirtualBox:pvr1.2: dmi.product.name: VirtualBox dmi.product.version: 1.2 dmi.sys.vendor: innotek GmbH version.compiz: compiz 1:0.9.5.94+bzr2803-0ubuntu5 version.libdrm2: libdrm2 2.4.26-1ubuntu1 version.libgl1-mesa-dri: libgl1-mesa-dri 7.11-0ubuntu3 version.libgl1-mesa-dri-experimental: libgl1-mesa-dri-experimental N/A version.libgl1-mesa-glx: libgl1-mesa-glx 7.11-0ubuntu3 version.xserver-xorg: xserver-xorg 1:7.6+7ubuntu7 version.xserver-xorg-input-evdev: xserver-xorg-input-evdev 1:2.6.0-1ubuntu13 version.xserver-xorg-video-ati: xserver-xorg-video-ati 1:6.14.99~git20110811.g93fc084-0ubuntu1 version.xserver-xorg-video-intel: xserver-xorg-video-intel 2:2.15.901-1ubuntu2 version.xserver-xorg-video-nouveau: xserver-xorg-video-nouveau 1:0.0.16+git20110411+8378443-1
2011-09-18 10:50:04 Omer Akram branch linked lp:~om26er/unity/unity-fix-852984
2011-09-18 10:51:11 Omer Akram unity: assignee Wildjiji (wildjiji)
2011-09-18 10:51:20 Omer Akram unity (Ubuntu): assignee Wildjiji (wildjiji)
2011-09-18 10:51:22 Omer Akram unity: status Confirmed Incomplete
2011-09-18 10:51:24 Omer Akram unity (Ubuntu): status Confirmed Incomplete
2011-09-18 10:51:30 Omer Akram unity: status Incomplete In Progress
2011-09-18 10:51:32 Omer Akram unity (Ubuntu): status Incomplete In Progress
2011-09-18 11:31:27 Omer Akram unity: milestone 4.18.0
2011-09-26 07:19:59 Neil J. Patel unity: status In Progress Fix Committed
2011-09-26 07:20:02 Neil J. Patel unity (Ubuntu): status In Progress Fix Committed
2011-09-26 10:23:03 Didier Roche-Tolomelli unity: status Fix Committed Fix Released
2011-09-26 12:44:25 Launchpad Janitor branch linked lp:~ubuntu-desktop/unity/ubuntu
2011-09-26 13:42:49 Launchpad Janitor unity (Ubuntu): status Fix Committed Fix Released
2011-09-26 14:10:30 Launchpad Janitor branch linked lp:ubuntu/unity