[FFE] Centered layout for expo plugin
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Invalid
|
Undecided
|
Unassigned | ||
Unity |
Fix Released
|
Wishlist
|
Sam Spilsbury | ||
compiz-plugins-main (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
Binary package hint: unity
This is a request for a feature freeze exception for the expo plugin of compiz.
DX will be adding two new options with default keys "X Space" and "Y Space" which affects the layout of the spread view to allow the launcher and panel to reserve space there on either side of the screen. This more closely matches the visual design targets for Natty, and in addition, the old layout just looked inconsistent due to the incorrect visual spacing.
See screenshot of the new layout: http://
CONTINGENCY PLAN:
The code adds two new options "Space X" and "Space Y" - if we do not feel this change is appropriate, changing those values to "0" will essentially mimic the old behaviour. The options code in this case is autogenerated and the same for all other options - well tested.
TESTING PLAN:
We need testers on different screen resolutions (the code should work for different resolutions) to make sure that the expo view is visually correct on their screen resolution.
DIFF:
+ float xoffset = ((vpSize.x () * sx) / ((float) screen->width ()) * optionGetXOffset ()) * sigmoidProgress (expoCam);
41 + float yoffset = ((vpSize.y () * sy) / ((float) screen->height ()) * optionGetYOffset ()) * sigmoidProgress (expoCam);
42 + float xadjs = 1.0f - ((float) optionGetXOffset () / (float) screen->width ()) * sigmoidProgress (expoCam);
43 + float yadjs = 1.0f - ((float) optionGetYOffset () / (float) screen->height ()) * sigmoidProgress (expoCam);
44 +
45 /* translate expo to center */
46 - sTransform.
47 - vpSize.y () * sy * 0.5, 0.0f);
48 + sTransform.
49 + vpSize.y () * sy * 0.5 - yoffset, 0.0f);
50 + sTransform.scale (xadjs, yadjs, 1.0f);
(See: https:/
Changed in unity: | |
milestone: | none → 3.8.8 |
status: | New → Fix Committed |
importance: | Undecided → Wishlist |
assignee: | nobody → Sam "SmSpillaz" Spilsbury (smspillaz) |
Changed in compiz-plugins-main (Ubuntu): | |
status: | New → Fix Committed |
importance: | Undecided → Wishlist |
Changed in unity (Ubuntu): | |
importance: | Undecided → Wishlist |
Changed in compiz: | |
status: | New → Invalid |
Changed in unity (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in unity: | |
status: | Fix Committed → Fix Released |
The change seems relatively harmless to me. However, I fail to see where https:/ /code.launchpad .net/~unity- team/compiz/ plugins- main-trunk. fixes-2011- 03-04/+ merge/56919 actually sets the default offsets? I thought the point was to basically move the empty space on the right to the left where the launcher is, so certainly we'd need some default values here?
OK if we can land this for beta-2.