Opening quicklist with launcher keynav returns focus to previous window

Bug #750781 reported by Dylan McCall on 2011-04-04
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Low
Jason Smith
unity (Ubuntu)
Low
Manuel Nicetto
Natty
Undecided
Unassigned

Bug Description

Test Case:

1.) Focus an application window, e.g. gedit
2.) Hit Alt-F1 to enter the launcher's keyboard-navigation
3.) Move the keyboard-navigation highlight down twice by pressing CursorDown two times
4.) Open the highlighted icon's quicklist by pressing CursorRight once
5.) The initially focused window should still have its focus (gedit in this example)

Binary package hint: unity

Press Alt+F1 to focus the launcher. Note that the window which was previously focused is now unfocused. Use the keyboard to open an item's quicklist (I used the right arrow), and note that the window is now focused. The window is focused and unfocused as we open and close the quicklist. This is pretty distracting.

Either the quicklist should steal focus when accessed via keynav or the launcher shouldn't :)

Related branches

Alex Launi (alexlauni) on 2011-04-13
Changed in unity:
status: New → Confirmed
Changed in unity (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
tags: added: bitesize
Changed in unity:
importance: Undecided → Low
Changed in unity:
assignee: nobody → Manuel Nicetto (manuel-nicetto)
status: Confirmed → Fix Committed
Changed in unity (Ubuntu):
assignee: nobody → Manuel Nicetto (manuel-nicetto)
status: Confirmed → Fix Committed
Sebastien Bacher (seb128) wrote :

Why did you set it to fix commited? where is the fix available for review?

Manuel Nicetto (manuel-nicetto) wrote :

i've pushed it in https://code.launchpad.net/~manuel-nicetto/unity/bug-750781. It's my first bug fix i've followed the UDD tutorial on the Dev Week. If it's not ok let me know so i can fix it....

Didier Roche (didrocks) wrote :

@Manuel: thanks for your branch! In fact, you should propose it for merge again trunk. I just did that for you. That's the easy way for us to review your changes :)

We are freezing review those days, so the review can take longer than usual, but don't be afraid, you will be able to follow the discussion on https://code.launchpad.net/~manuel-nicetto/unity/bug-750781/+merge/59389 :)

Thanks again for your work and helping to make unity better!

Changed in unity:
status: Fix Committed → In Progress
Changed in unity (Ubuntu):
status: Fix Committed → In Progress
Didier Roche (didrocks) on 2011-05-26
Changed in unity:
milestone: none → 3.8.14
Mirco Müller (macslow) on 2011-05-26
Changed in unity:
status: In Progress → Fix Committed
Mirco Müller (macslow) on 2011-05-26
description: updated
Didier Roche (didrocks) on 2011-05-26
Changed in unity:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.8.14-0ubuntu1

---------------
unity (3.8.14-0ubuntu1) oneiric; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Changed in unity (Ubuntu):
status: In Progress → Fix Released

Accepted unity into natty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in unity (Ubuntu Natty):
status: New → Fix Committed
tags: added: verification-needed
Bilal Akhtar (bilalakhtar) wrote :

I can still reproduce this bug on my Natty box running Unity 3.8.14 from -proposed. When I open the quicklist using keynav, the previously focused window gets focused. If I close it by pressing left arrow, the window gets unfocused again. The distracting behavior continues.

verification-failed?

tags: added: verification-failed
removed: verification-needed
Manuel Nicetto (manuel-nicetto) wrote :

I confirm that the bug still exists. I've tested it with the current trunk from lp:unity. The preserve_focus flag in the exit_keynav ubus event now means "return focus on last opened window on exit" instead of "preserve focus to the launcher". So i have to commit another fix, should i open a new bug for this? Note that this cause another bug: if you exit from keynav mode with the esc key, the launcher closes but the focus is not returned to the active window correctly.

Martin Pitt (pitti) wrote :

This is not a regression, so this doesn't block propagation of the proposed package to -updates.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity - 3.8.14-0ubuntu1~natty1

---------------
unity (3.8.14-0ubuntu1~natty1) natty-proposed; urgency=low

  * New upstream bug-fix release.
    - In a dual monitor setup with different resolutions, Unity places windows
      in the "dead zone" (LP: #752098)
    - Left pixel of launcher is not clickable on session start (LP: #758026)
    - unity crashed with AttributeError in reset_unity_compiz_profile(): 'str'
      object has no attribute 'get_string' (LP: #737320)
    - unity --reset crashes with NameError (LP: #774280)
    - Bottom icon on launcher tilts when it maybe shouldn't if icons fill
      launcher nearly exactly (LP: #728949)
    - Dodge active window - launcher should not show when modal dialog is
      opened (LP: #718185)
    - Unity maximizes windows that don't support resize on launch (LP: #769781)
    - compiz crashed with SIGSEGV in sigc::signal_base::impl() (LP: #762801)
    - inactive menus becomes brighter on sub-sequent clicks (LP: #733740)
    - Unity crashes when dynamic quicklist dbusmenu contains a hidden menuitem.
      (LP: #759174)
    - Opening quicklist with launcher keynav returns focus to previous window
      (LP: #750781)
    - window's title does not fade in the right position (LP: #722178)
  * debian/control:
    - depends on compiz for some people upgrading (LP: #773253)
  * debian/patches/01_add_scp_to_systray.patch:
    - remove, upstream now
 -- Didier Roche <email address hidden> Thu, 26 May 2011 17:41:14 +0200

Changed in unity (Ubuntu Natty):
status: Fix Committed → Fix Released
Martin Pitt (pitti) wrote :

Reopening due to confirmed verification failure.

Changed in unity (Ubuntu):
status: Fix Released → Triaged
Didier Roche (didrocks) on 2011-06-09
Changed in unity:
milestone: 3.8.14 → 3.8.16
status: Fix Released → Triaged
assignee: Manuel Nicetto (manuel-nicetto) → nobody
Changed in unity (Ubuntu):
assignee: Manuel Nicetto (manuel-nicetto) → nobody
Changed in unity (Ubuntu Natty):
status: Fix Released → Triaged
Changed in unity (Ubuntu):
assignee: nobody → Manuel Nicetto (manuel-nicetto)
status: Triaged → In Progress
Martin Pitt (pitti) on 2011-06-09
Changed in unity (Ubuntu):
status: In Progress → Confirmed
Changed in unity (Ubuntu Natty):
status: Triaged → Confirmed
Didier Roche (didrocks) on 2011-06-09
Changed in unity (Ubuntu):
status: Confirmed → Triaged
Changed in unity (Ubuntu):
status: Triaged → In Progress
Didier Roche (didrocks) on 2011-06-14
Changed in unity:
status: Triaged → In Progress
David Barth (dbarth) wrote :

Jason: can you review the patch and integrate if it passes. Thanks

Changed in unity:
assignee: nobody → Jason Smith (jassmith)
milestone: 3.8.16 → 3.8.18
Omer Akram (om26er) wrote :

This is not an issue in Oneirc anymore, when keyboard navigation starts focus is lost from the app as it ends the app is again focused, I don't see any reason for an SRU in this case, i'd recommend wontfix for Natty.

Changed in unity:
status: In Progress → Fix Released
Changed in unity (Ubuntu):
status: In Progress → Fix Released
Omer Akram (om26er) on 2012-02-05
Changed in unity (Ubuntu Natty):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers