Comment 33 for bug 1206268

Jamie Strandboge (jdstrand) wrote :

webbrowser-app review:
 * builds fine with universe depends
 * has a testsuite and it runs during the build (plus there are autopilot tests)
 * packaging is clean
 * Ubuntu-only, no libraries
 * has a bug subscriber (ubuntu-apps-bugs)
 * should be built with all hardening options since it processes untrusted content (ie, build with normal options plus PIE and RELRO)
 * two compiler warnings:
   src/app/EmbeddedProgressBar.qml:41: warning: unterminated string literal
   src/app/EmbeddedProgressBar.qml:57: warning: unterminated string literal
 * one lintian error (there are also warnings that should be fixed):
   E: qtdeclarative5-ubuntu-ui-extras-browser-plugin: pkg-has-shlibs-control-file-but-no-actual-shared-libs
 * no CVE history
 * uses QtWebKit.experimental, but uses the defaults for SSL and does not override with onIgnoreSSLErrors (good). Doesn't provide a useful error message with certificate errors (bug #1227055), but it does perform certificate verification so this isn't a blocker or security concern.
 * uses webkit for now, but the plan is to move to oxide as soon as possible

Conditional ACK provided PIE and RELRO are enabled, the compiler warnings are addressed and the lintian error is fixed (bonus points for fixing the warnings).