| 2014-03-20 17:35:33 |
Charles Kerr |
bug |
|
|
added bug |
| 2014-03-20 17:36:19 |
Charles Kerr |
attachment added |
|
popey's screenshot https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/1295271/+attachment/4034428/+files/device-2014-03-20-123802.png |
|
| 2014-03-20 17:36:44 |
Charles Kerr |
bug task added |
|
unity-notifications (Ubuntu) |
|
| 2014-03-20 17:37:50 |
Charles Kerr |
description |
Reported by Popey @ http://popey.com/~alan/phablet/device-2014-03-20-123802.png
Part of this is fairly straightforward. The code that generates the snap decision is shown at http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.
The relevant bit is that the two actions are added to the notification only if (mode == NOTIFY_MODE_SNAP):
> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
> notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
> notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);
Where the mode is chosen based on this:
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205
i.e., if the notification server doesn't say that it supports actions, we fall back to bubble notification instead.
I see a TODO item in indicator-datetime would be to add some debugging information here so that we can report exactly what server caps we got back from libnotify. In addition, since this is being reported at the same time that davmor2 is reporting bug #1295237, I think it makes sense to pull unity-notifications into this for more pairs of eyes. |
Reported by Popey @ http://popey.com/~alan/phablet/device-2014-03-20-123802.png
Part of the cause for this is fairly straightforward. The code that generates the snap decision is shown at http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.
The relevant bit is that the two actions are added to the notification only if (mode == NOTIFY_MODE_SNAP):
> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
> notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
> notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);
Where the mode is chosen based on this:
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205
i.e., if the notification server doesn't say that it supports actions, we fall back to bubble notification instead.
I see a TODO item in indicator-datetime would be to add some debugging information here so that we can report exactly what server caps we got back from libnotify. In addition, since this is being reported at the same time that davmor2 is reporting bug #1295237, I think it makes sense to pull unity-notifications into this for more pairs of eyes. |
|
| 2014-03-20 17:44:13 |
Charles Kerr |
indicator-datetime (Ubuntu): status |
New |
Triaged |
|
| 2014-03-20 17:47:30 |
Charles Kerr |
description |
Reported by Popey @ http://popey.com/~alan/phablet/device-2014-03-20-123802.png
Part of the cause for this is fairly straightforward. The code that generates the snap decision is shown at http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.
The relevant bit is that the two actions are added to the notification only if (mode == NOTIFY_MODE_SNAP):
> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
> notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
> notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);
Where the mode is chosen based on this:
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205
i.e., if the notification server doesn't say that it supports actions, we fall back to bubble notification instead.
I see a TODO item in indicator-datetime would be to add some debugging information here so that we can report exactly what server caps we got back from libnotify. In addition, since this is being reported at the same time that davmor2 is reporting bug #1295237, I think it makes sense to pull unity-notifications into this for more pairs of eyes. |
Reported by Popey @ http://popey.com/~alan/phablet/device-2014-03-20-123802.png
Part of the cause for this is fairly straightforward. The code that generates the snap decision is shown at http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.
The relevant bit is that the two actions are added to the notification only if (mode == NOTIFY_MODE_SNAP):
> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
> notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
> notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);
Where the mode is chosen based on this:
http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205
i.e., if the notification server doesn't say that it supports actions, we fall back to bubble notification instead. That also may explain the reports of no sound being played, since we don't play sounds unless the popup can be dismissed.
(This no-buttons-no-sound-just-a-popup behavior is intended for the desktop, where notifications don't support actions. When working properly, unity-notifications tells its clients that it supports actions.)
I see a TODO item in indicator-datetime would be to add some debugging information here so that we can report exactly what server caps we got back from libnotify. In addition, since this is being reported at the same time that davmor2 is reporting bug #1295237, I think it makes sense to pull unity-notifications into this for more pairs of eyes. |
|
| 2014-03-20 18:36:46 |
Charles Kerr |
branch linked |
|
lp:~charlesk/indicator-datetime/lp-1295271 |
|
| 2014-03-21 11:16:21 |
Launchpad Janitor |
indicator-datetime (Ubuntu): status |
Triaged |
Fix Released |
|
