On phone, alarms being shown without dismiss/show buttons

[Charles Kerr]

Reported by Popey @ http://popey.com/~alan/phablet/device-2014-03-20-123802.png

Part of the cause for this is fairly straightforward. The code that generates the snap decision is shown at http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.

The relevant bit is that the two actions are added to the notification only if (mode == NOTIFY_MODE_SNAP):

> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
> notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
> notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);

Where the mode is chosen based on this:

http://bazaar.launchpad.net/~indicator-applet-developers/indicator-datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205

i.e., if the notification server doesn't say that it supports actions, we fall back to bubble notification instead. That also may explain the reports of no sound being played, since we don't play sounds unless the popup can be dismissed.

(This no-buttons-no-sound-just-a-popup behavior is intended for the desktop, where notifications don't support actions. When working properly, unity-notifications tells its clients that it supports actions.)

I see a TODO item in indicator-datetime would be to add some debugging information here so that we can report exactly what server caps we got back from libnotify. In addition, since this is being reported at the same time that davmor2 is reporting bug #1295237, I think it makes sense to pull unity-notifications into this for more pairs of eyes.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-datetime - 13.10.0+14.04.20140321-0ubuntu1

---------------
indicator-datetime (13.10.0+14.04.20140321-0ubuntu1) trusty; urgency=low

  [ Charles Kerr ]
  * If we notify_notification_show() fails, we shouldn't play the alarm
    sound. The alarm sound loops until the user dismisses it, which will
    never happen if we can't talk to unity-notiifications. So the
    outcome in this error case is that the alarm plays forever and can't
    be dismissed by the user. (LP: #1295237)
  * Add debug logging of what capabilities the notification server said
    it supports. (LP: #1295271)
 -- Ubuntu daily release <email address hidden> Fri, 21 Mar 2014 05:23:04 +0000